linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Jiri Olsa <jolsa@redhat.com>, Mike Galbraith <efault@gmx.de>,
	Namhyung Kim <namhyung@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	Stephane Eranian <eranian@google.com>
Subject: [PATCH V4 6/9] perf tools: find kcore symbols on other maps
Date: Mon,  7 Oct 2013 09:50:15 +0300	[thread overview]
Message-ID: <1381128618-22721-7-git-send-email-adrian.hunter@intel.com> (raw)
In-Reply-To: <1381128618-22721-1-git-send-email-adrian.hunter@intel.com>

Use the new map__find_other_map_symbol() to
find kcore symbols on other maps.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 tools/perf/util/annotate.c | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
index 46746b8..6cb7277 100644
--- a/tools/perf/util/annotate.c
+++ b/tools/perf/util/annotate.c
@@ -825,20 +825,15 @@ static int symbol__parse_objdump_line(struct symbol *sym, struct map *map,
 		dl->ops.target.offset = dl->ops.target.addr -
 					map__rip_2objdump(map, sym->start);
 
-	/*
-	 * kcore has no symbols, so add the call target name if it is on the
-	 * same map.
-	 */
+	/* kcore has no symbols, so add the call target name */
 	if (dl->ins && ins__is_call(dl->ins) && !dl->ops.target.name) {
+		struct map *map_ptr = map;
 		struct symbol *s;
 		u64 ip = dl->ops.target.addr;
 
-		if (ip >= map->start && ip <= map->end) {
-			ip = map->map_ip(map, ip);
-			s = map__find_symbol(map, ip, NULL);
-			if (s && s->start == ip)
-				dl->ops.target.name = strdup(s->name);
-		}
+		s = map__find_other_map_symbol(&map_ptr, &ip, NULL);
+		if (s && s->start == ip)
+			dl->ops.target.name = strdup(s->name);
 	}
 
 	disasm__add(&notes->src->source, dl);
-- 
1.7.11.7


  parent reply	other threads:[~2013-10-07  6:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-07  6:50 [PATCH V4 0/9] perf tools: kcore improvements Adrian Hunter
2013-10-07  6:50 ` [PATCH V4 1/9] perf tools: make a separate function to parse /proc/modules Adrian Hunter
2013-10-07  6:50 ` [PATCH V4 2/9] perf tools: validate kcore module addresses Adrian Hunter
2013-10-08  7:18   ` Namhyung Kim
2013-10-07  6:50 ` [PATCH V4 3/9] perf tools: workaround objdump difficulties with kcore Adrian Hunter
2013-10-07  6:50 ` [PATCH V4 4/9] perf tools: add map__find_other_map_symbol() Adrian Hunter
2013-10-07  6:50 ` [PATCH V4 5/9] perf tools: fix annotate_browser__callq() Adrian Hunter
2013-10-07  6:50 ` Adrian Hunter [this message]
2013-10-07  6:50 ` [PATCH V4 7/9] perf tools: add copyfile_mode() Adrian Hunter
2013-10-07  6:50 ` [PATCH V4 8/9] perf buildid-cache: add ability to add kcore to the cache Adrian Hunter
2013-10-08  7:41   ` Namhyung Kim
2013-10-08  8:05     ` Adrian Hunter
2013-10-08  8:34       ` Namhyung Kim
2013-10-07  6:50 ` [PATCH V4 9/9] perf tools: add ability to find kcore in build-id cache Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381128618-22721-7-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=efault@gmx.de \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).