From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
<industrypack-devel@lists.sourceforge.net>
Subject: [PATCH 2/8] ipack: convert bus code to use dev_groups
Date: Mon, 7 Oct 2013 18:27:36 -0700 [thread overview]
Message-ID: <1381195662-28009-3-git-send-email-gregkh@linuxfoundation.org> (raw)
In-Reply-To: <1381195662-28009-1-git-send-email-gregkh@linuxfoundation.org>
The dev_attrs field of struct bus_type is going away soon, dev_groups
should be used instead. This converts the ipack bus code to use the
correct field.
Cc: Samuel Iglesias Gonsalvez <siglesias@igalia.com>
Cc: Jens Taprogge <jens.taprogge@taprogge.org>
Cc: <industrypack-devel@lists.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Samuel and Jens, I can take this through my driver-core tree if you
don't want to take it through yours, just let me know what works best
for you.
drivers/ipack/ipack.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c
index 6e066c5..d0016ba 100644
--- a/drivers/ipack/ipack.c
+++ b/drivers/ipack/ipack.c
@@ -180,20 +180,28 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
ipack_device_attr(id_format, "0x%hhu\n");
-static struct device_attribute ipack_dev_attrs[] = {
- __ATTR_RO(id),
- __ATTR_RO(id_device),
- __ATTR_RO(id_format),
- __ATTR_RO(id_vendor),
- __ATTR_RO(modalias),
+static DEVICE_ATTR_RO(id);
+static DEVICE_ATTR_RO(id_device);
+static DEVICE_ATTR_RO(id_format);
+static DEVICE_ATTR_RO(id_vendor);
+static DEVICE_ATTR_RO(modalias);
+
+static struct attribute *ipack_attrs[] = {
+ &dev_attr_id.attr,
+ &dev_attr_id_device.attr,
+ &dev_attr_id_format.attr,
+ &dev_attr_id_vendor.attr,
+ &dev_attr_modalias.attr,
+ NULL,
};
+ATTRIBUTE_GROUPS(ipack);
static struct bus_type ipack_bus_type = {
.name = "ipack",
.probe = ipack_bus_probe,
.match = ipack_bus_match,
.remove = ipack_bus_remove,
- .dev_attrs = ipack_dev_attrs,
+ .dev_groups = ipack_groups,
.uevent = ipack_uevent,
};
--
1.8.4.6.g82e253f.dirty
next prev parent reply other threads:[~2013-10-08 2:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 1:27 [PATCH 0/8] driver core bus cleanup to use dev_groups, round 2 Greg Kroah-Hartman
2013-10-08 1:27 ` [PATCH 1/8] ide: convert bus code to use dev_groups Greg Kroah-Hartman
2013-10-08 5:00 ` David Miller
2013-10-08 1:27 ` Greg Kroah-Hartman [this message]
2013-10-08 6:26 ` [PATCH 2/8] ipack: " Samuel Iglesias Gonsálvez
2013-10-08 1:27 ` [PATCH 3/8] input: gameport: " Greg Kroah-Hartman
2013-10-08 1:27 ` [PATCH 4/8] spi: " Greg Kroah-Hartman
2013-10-08 9:35 ` Mark Brown
2013-10-08 1:27 ` [PATCH 5/8] virtio: " Greg Kroah-Hartman
2013-10-08 1:27 ` [PATCH 6/8] tifm: " Greg Kroah-Hartman
2013-10-08 1:27 ` [PATCH 7/8] memstick: " Greg Kroah-Hartman
2013-10-08 1:27 ` [PATCH 8/8] i2o: " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381195662-28009-3-git-send-email-gregkh@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siglesias@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).