From: "Matias Bjørling" <m@bjorling.me>
To: axboe@kernel.dk, willy@linux.intel.com
Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
"Matias Bjørling" <m@bjorling.me>
Subject: [PATCH RFC 1/2] blk-mq: call exit_hctx on hw queue teardown
Date: Tue, 8 Oct 2013 11:34:21 +0200 [thread overview]
Message-ID: <1381224862-5299-2-git-send-email-m@bjorling.me> (raw)
In-Reply-To: <1381224862-5299-1-git-send-email-m@bjorling.me>
The driver initialize itself using init_hctx and reverts using exit_hctx if
unsucessful. exit_hctx is missing on normal hw queue teardown.
Signed-off-by: Matias Bjørling <m@bjorling.me>
---
block/blk-mq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 923e9e1..5b054b7 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1390,6 +1390,8 @@ void blk_mq_free_queue(struct request_queue *q)
kfree(hctx->ctxs);
blk_mq_free_rq_map(hctx);
blk_mq_unregister_cpu_notifier(&hctx->cpu_notifier);
+ if (q->mq_ops->exit_hctx)
+ q->mq_ops->exit_hctx(hctx, i);
q->mq_ops->free_hctx(hctx, i);
}
--
1.8.1.2
next prev parent reply other threads:[~2013-10-08 9:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 9:34 [PATCH RFC 0/2] Convert from bio-based to blk-mq Matias Bjørling
2013-10-08 9:34 ` Matias Bjørling [this message]
2013-10-08 9:34 ` [PATCH RFC 2/2] NVMe: rfc blk-mq support Matias Bjørling
2013-10-08 20:59 ` Keith Busch
2013-10-09 7:12 ` Matias Bjørling
2013-10-08 13:10 ` [PATCH RFC 0/2] Convert from bio-based to blk-mq Matthew Wilcox
2013-10-08 13:19 ` Matias Bjørling
2013-10-08 18:39 ` Jens Axboe
2013-10-09 15:48 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381224862-5299-2-git-send-email-m@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).