public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <bitbucket@online.de>
To: Stephane Eranian <eranian@google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: perf: perf sched lat segfault - bisected
Date: Tue, 08 Oct 2013 12:50:21 +0200	[thread overview]
Message-ID: <1381229421.15686.17.camel@marge.simpson.net> (raw)
In-Reply-To: <CABPqkBSpTPttig8uKdR2KJba8rwOe3P1sKPjkVizVGH=H+w-9Q@mail.gmail.com>

On Tue, 2013-10-08 at 12:36 +0200, Stephane Eranian wrote: 
> Mike,
> 
> I found the problem in perf. The tool->mmap2 pointer is NULL for sched tool.
> Let me send you a patch to fix this.

Ah, no need.  It's probably something like so, which fixed it.

diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c 
index d8c51b2f263f..a60d14dd18e7 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1658,6 +1658,7 @@ static struct perf_sched sched = {
                .comm            = perf_event__process_comm,
                .lost            = perf_event__process_lost,
                .fork            = perf_sched__process_fork_event,
+               .mmap2           = perf_event__process_mmap2,
                .ordered_samples = true,
        },
        .cmp_pid              = LIST_HEAD_INIT(sched.cmp_pid),



  reply	other threads:[~2013-10-08 10:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08  8:41 perf: perf sched lat segfault - bisected Mike Galbraith
2013-10-08  9:23 ` Stephane Eranian
2013-10-08 10:14   ` Mike Galbraith
2013-10-08 10:20     ` Mike Galbraith
2013-10-08 10:25       ` Stephane Eranian
2013-10-08 10:36         ` Stephane Eranian
2013-10-08 10:50           ` Mike Galbraith [this message]
2013-10-08 10:51             ` Stephane Eranian
2013-10-08 10:56               ` Mike Galbraith
2013-10-08 10:57                 ` Stephane Eranian
2013-10-08 10:41         ` Mike Galbraith
2013-10-08 12:17 ` Arnaldo Carvalho de Melo
2013-10-08 12:27   ` Mike Galbraith
2013-10-08 12:35     ` Mike Galbraith
2013-10-08 13:20       ` David Ahern
2013-10-08 13:44         ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381229421.15686.17.camel@marge.simpson.net \
    --to=bitbucket@online.de \
    --cc=acme@redhat.com \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox