Re: perf: perf sched lat segfault - bisected

Stephane Eranian
2013-10-08T10:51:17Z

Mike,

I posted the fix now. It was somewhere else. But you got the idea.
thanks for reporting the problem.

On Tue, Oct 8, 2013 at 12:50 PM, Mike Galbraith <bitbucket@online.de> wrote:
> On Tue, 2013-10-08 at 12:36 +0200, Stephane Eranian wrote:
>> Mike,
>>
>> I found the problem in perf. The tool->mmap2 pointer is NULL for sched tool.
>> Let me send you a patch to fix this.
>
> Ah, no need. It's probably something like so, which fixed it.
>
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index d8c51b2f263f..a60d14dd18e7 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -1658,6 +1658,7 @@ static struct perf_sched sched = {
> .comm = perf_event__process_comm,
> .lost = perf_event__process_lost,
> .fork = perf_sched__process_fork_event,
> + .mmap2 = perf_event__process_mmap2,
> .ordered_samples = true,
> },
> .cmp_pid = LIST_HEAD_INIT(sched.cmp_pid),
>
>