From: Joe Perches <joe@perches.com>
To: Ryan Mallon <rmallon@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
eldad@fogrefinery.com, Jiri Kosina <jkosina@suse.cz>,
jgunthorpe@obsidianresearch.com,
Dan Rosenberg <dan.j.rosenberg@gmail.com>,
Kees Cook <keescook@chromium.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@xmission.com>,
George Spelvin <linux@horizon.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3a] vsprintf: Check real user/group id for %pK
Date: Wed, 09 Oct 2013 16:21:51 -0700 [thread overview]
Message-ID: <1381360911.2050.47.camel@joe-AO722> (raw)
In-Reply-To: <5255E446.2000400@gmail.com>
On Thu, 2013-10-10 at 10:18 +1100, Ryan Mallon wrote:
> On 10/10/13 10:09, Joe Perches wrote:
> > Do the in_irq tests only when kptr_restrict is 1.
> > Document the %pK mechanism in vsnprintf
> > Add missing documentation for %pV and %pNF too
>
> I really did mean post a follow-up/separate patch, not a different
> version of mine.
I think that's not the right thing to do.
There's no good reason to have multiple commits
for the same content.
And almost all of that is actually stuff I wrote.
Your content there is the cred checks.
> > + cred = current_cred();
> > + if (!has_capability_noaudit(current, CAP_SYSLOG) ||
> > + !uid_eq(cred->euid, cred->uid) ||
> > + !gid_eq(cred->egid, cred->gid))
next prev parent reply other threads:[~2013-10-09 23:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-09 21:52 [PATCH v3] vsprintf: Check real user/group id for %pK Ryan Mallon
2013-10-09 22:00 ` Joe Perches
2013-10-09 22:04 ` Ryan Mallon
2013-10-09 22:14 ` Joe Perches
2013-10-09 22:25 ` Ryan Mallon
2013-10-09 22:33 ` Joe Perches
2013-10-09 22:42 ` Ryan Mallon
2013-10-09 23:09 ` [PATCH v3a] " Joe Perches
2013-10-09 23:18 ` Ryan Mallon
2013-10-09 23:21 ` Joe Perches [this message]
2013-10-11 2:20 ` Eric W. Biederman
2013-10-11 3:19 ` Ryan Mallon
2013-10-11 3:34 ` Eric W. Biederman
2013-10-14 10:17 ` Djalal Harouni
2013-10-14 12:21 ` Djalal Harouni
2013-10-14 20:41 ` Ryan Mallon
2013-10-11 4:42 ` George Spelvin
2013-10-11 5:19 ` Ryan Mallon
2013-10-11 5:29 ` Joe Perches
2013-10-11 22:04 ` Ryan Mallon
2013-10-11 22:37 ` Eric W. Biederman
2013-10-14 9:18 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381360911.2050.47.camel@joe-AO722 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.rosenberg@gmail.com \
--cc=ebiederm@xmission.com \
--cc=eldad@fogrefinery.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=jkosina@suse.cz \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=rmallon@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox