Re: [PATCH v2 09/10] intel_mid: Moved board related code to a new file

sathyanarayanan.kuppuswamy
2013-10-10T19:27:58Z

> On Wed, Oct 09, 2013 at 11:00:06PM -0700, David Cohen wrote:
>> From: Kuppuswamy Sathyanarayanan
>> <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> +# I2C Devices
>> +obj-$(subst m,y,$(CONFIG_SENSORS_EMC1403)) += platform_emc1403.o
>> +obj-$(subst m,y,$(CONFIG_SENSORS_LIS3LV02D)) += platform_lis331.o
>
> I am a bit confused by the platform data for the above i2c devices.
> The driver for EMC1403 does supports neither interrupts nor platform data.
> The driver for LIS3LV02D supports both, but the platform data does not
> seem to match what is provided here. Am I missing something ?

I did not add anything new here. I just moved the code from mrst.c to the
respective platform data files. I am not sure whether the driver uses this
data or not. If this code needs to be fixed , we can probably do it in a
different patch.

>
>> +obj-$(subst m,y,$(CONFIG_GPIO_PCA953X)) += platform_max7315.o
>> +obj-$(subst m,y,$(CONFIG_SENSORS_MPU3050)) += platform_mpu3050.o
>
> Do you possibly mean CONFIG_INPUT_MPU3050 ?

Thanks for pointing it. I will fix it in next patchset.

>
> Guenter
>
Sathya