From: Mark Salter <msalter@redhat.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Catalin Marinas <Catalin.Marinas@arm.com>
Subject: Re: [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script
Date: Fri, 11 Oct 2013 08:18:41 -0400 [thread overview]
Message-ID: <1381493921.8305.63.camel@deneb.redhat.com> (raw)
In-Reply-To: <20131009101447.GC5985@mudshark.cambridge.arm.com>
On Wed, 2013-10-09 at 11:14 +0100, Will Deacon wrote:
> > @@ -110,6 +110,7 @@ SECTIONS
> > */
> > INIT_TASK_DATA(THREAD_SIZE)
> > NOSAVE_DATA
> > + PAGE_ALIGNED_DATA(PAGE_SIZE)
> > CACHELINE_ALIGNED_DATA(64)
> > READ_MOSTLY_DATA(64)
>
> Can we just replace this chunk with RW_DATA_SECTION(64, PAGE_SIZE,
> THREAD_SIZE) instead?
>
I took a look at this. It can be done, but the RW_DATA_SECTION aligns
data to PAGE_SIZE where the existing alignment is THREAD_SIZE. So using
RW_DATA_SECTION would waste some space if using 64K pagesize.
--Mark
next prev parent reply other threads:[~2013-10-11 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 20:37 [PATCH] arm64: add PAGE_ALIGNED_DATA to linker script Mark Salter
2013-10-09 10:14 ` Will Deacon
2013-10-09 17:31 ` Mark Salter
2013-10-11 12:18 ` Mark Salter [this message]
2013-11-01 15:01 ` Mark Salter
2013-11-01 16:17 ` Will Deacon
2013-11-04 11:28 ` Catalin Marinas
2013-11-04 16:38 ` [PATCH] arm64: use generic RW_DATA_SECTION macro in " Mark Salter
2013-11-04 17:20 ` Will Deacon
2013-11-04 18:19 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381493921.8305.63.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=Catalin.Marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox