From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 11/12] tracing: fix tracing_snapshot kerneldoc
Date: Fri, 11 Oct 2013 08:29:43 -0500 [thread overview]
Message-ID: <1381498183.19281.12.camel@empanada> (raw)
In-Reply-To: <5257F408.9040503@hitachi.com>
On Fri, 2013-10-11 at 21:50 +0900, Masami Hiramatsu wrote:
> (2013/10/11 9:48), Tom Zanussi wrote:
> > The names of the functions are tracing_snapshot_*, not
> > trace_snapshot_* - fix up the kerneldoc to avoid confusion.
> >
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> It seems that this is not related this series.
> Please send it as a trivial fix patch :)
>
Yeah, I keep adding patches as I test things, and 4 of the patches in
this patchset now fit that description..
Tom
> Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>
> > ---
> > kernel/trace/trace.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index 5aa8f80..81d95bf 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -514,7 +514,7 @@ EXPORT_SYMBOL_GPL(__trace_bputs);
> >
> > #ifdef CONFIG_TRACER_SNAPSHOT
> > /**
> > - * trace_snapshot - take a snapshot of the current buffer.
> > + * tracing_snapshot - take a snapshot of the current buffer.
> > *
> > * This causes a swap between the snapshot buffer and the current live
> > * tracing buffer. You can use this to take snapshots of the live
> > @@ -617,9 +617,9 @@ int tracing_alloc_snapshot(void)
> > EXPORT_SYMBOL_GPL(tracing_alloc_snapshot);
> >
> > /**
> > - * trace_snapshot_alloc - allocate and take a snapshot of the current buffer.
> > + * tracing_snapshot_alloc - allocate and take a snapshot of the current buffer.
> > *
> > - * This is similar to trace_snapshot(), but it will allocate the
> > + * This is similar to tracing_snapshot(), but it will allocate the
> > * snapshot buffer if it isn't already allocated. Use this only
> > * where it is safe to sleep, as the allocation may sleep.
> > *
> >
>
>
next prev parent reply other threads:[~2013-10-11 13:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 0:48 [PATCH v10 00/12] tracing: trace event triggers Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 01/12] tracing: Add support for SOFT_DISABLE to syscall events Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 02/12] tracing: Add basic event trigger framework Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 03/12] tracing: Add 'traceon' and 'traceoff' event trigger commands Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 04/12] tracing: Add 'snapshot' event trigger command Tom Zanussi
2013-10-11 13:47 ` Masami Hiramatsu
2013-10-11 14:04 ` Tom Zanussi
2013-10-15 9:23 ` Masami Hiramatsu
2013-10-11 0:48 ` [PATCH v10 05/12] tracing: Add 'stacktrace' " Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 06/12] tracing: Add 'enable_event' and 'disable_event' event trigger commands Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 07/12] tracing: Add and use generic set_trigger_filter() implementation Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 08/12] tracing: Update event filters for multibuffer Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 09/12] tracing: Add documentation for trace event triggers Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 10/12] tracing: Make register/unregister_ftrace_command __init Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 11/12] tracing: fix tracing_snapshot kerneldoc Tom Zanussi
2013-10-11 12:50 ` Masami Hiramatsu
2013-10-11 13:29 ` Tom Zanussi [this message]
2013-10-11 20:57 ` Steven Rostedt
2013-10-11 0:48 ` [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE Tom Zanussi
2013-10-11 13:00 ` Masami Hiramatsu
2013-10-11 13:32 ` Tom Zanussi
2013-10-11 20:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381498183.19281.12.camel@empanada \
--to=tom.zanussi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox