From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE
Date: Fri, 11 Oct 2013 08:32:48 -0500 [thread overview]
Message-ID: <1381498368.19281.15.camel@empanada> (raw)
In-Reply-To: <5257F666.7080703@hitachi.com>
On Fri, 2013-10-11 at 22:00 +0900, Masami Hiramatsu wrote:
> (2013/10/11 9:48), Tom Zanussi wrote:
> > If CONFIG_STACKTRACE is turned off, trace_dump_stack() isn't defined,
> > resulting in an 'undefined reference' error - define a stub to remedy
> > that.
> >
> > Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
>
> Hmm, what kernel config caused that error?
> It seems that the CONFIG_STACKTRACE is forced on if it is required.
> And if you have found such case, IMHO, we should turn on the CONFIG_STACKTRACE
> in Kconfig.
Yeah, it's not easy to turn off CONFIG_STACKTRACE - I basically had to
tweak a couple Kconfigs to do it, so I could test my stacktrace trigger
CONFIG_STACKTRACE ifdefs.
Still, it's code that explicitly depends on CONFIG_STACKTRACE, so I
think it makes sense to ifdef it.
Tom
> (Also, if it is not related to this series, it should be reported as a separated
> bugfix :) )
>
> Thank you,
>
>
next prev parent reply other threads:[~2013-10-11 13:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 0:48 [PATCH v10 00/12] tracing: trace event triggers Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 01/12] tracing: Add support for SOFT_DISABLE to syscall events Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 02/12] tracing: Add basic event trigger framework Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 03/12] tracing: Add 'traceon' and 'traceoff' event trigger commands Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 04/12] tracing: Add 'snapshot' event trigger command Tom Zanussi
2013-10-11 13:47 ` Masami Hiramatsu
2013-10-11 14:04 ` Tom Zanussi
2013-10-15 9:23 ` Masami Hiramatsu
2013-10-11 0:48 ` [PATCH v10 05/12] tracing: Add 'stacktrace' " Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 06/12] tracing: Add 'enable_event' and 'disable_event' event trigger commands Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 07/12] tracing: Add and use generic set_trigger_filter() implementation Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 08/12] tracing: Update event filters for multibuffer Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 09/12] tracing: Add documentation for trace event triggers Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 10/12] tracing: Make register/unregister_ftrace_command __init Tom Zanussi
2013-10-11 0:48 ` [PATCH v10 11/12] tracing: fix tracing_snapshot kerneldoc Tom Zanussi
2013-10-11 12:50 ` Masami Hiramatsu
2013-10-11 13:29 ` Tom Zanussi
2013-10-11 20:57 ` Steven Rostedt
2013-10-11 0:48 ` [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE Tom Zanussi
2013-10-11 13:00 ` Masami Hiramatsu
2013-10-11 13:32 ` Tom Zanussi [this message]
2013-10-11 20:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381498368.19281.15.camel@empanada \
--to=tom.zanussi@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox