* [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list.
@ 2013-10-21 6:57 Chuong Ngo
2013-10-22 8:39 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Chuong Ngo @ 2013-10-21 6:57 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Chuong Ngo
Removed a debug message as outlined in the TODO list.
---
drivers/staging/bcm/Bcmchar.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index f91bc1f..526594b 100644
--- a/drivers/staging/bcm/Bcmchar.c
+++ b/drivers/staging/bcm/Bcmchar.c
@@ -50,8 +50,6 @@ static int bcm_char_release(struct inode *inode, struct file *filp)
pTarang = (struct bcm_tarang_data *)filp->private_data;
if (pTarang == NULL) {
- BCM_DEBUG_PRINT(Adapter, DBG_TYPE_PRINTK, 0, 0,
- "ptarang is null\n");
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list.
2013-10-21 6:57 [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list Chuong Ngo
@ 2013-10-22 8:39 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2013-10-22 8:39 UTC (permalink / raw)
To: Chuong Ngo; +Cc: gregkh, devel, linux-kernel
On Mon, Oct 21, 2013 at 02:57:24AM -0400, Chuong Ngo wrote:
> Removed a debug message as outlined in the TODO list.
The Signed-off-by line is missing. Run checkpatch.pl over your patch.
Hopefully it should warn you to remove the curly braced because they
are not needed any more.
Otherwise the patch is ok. Please fix the two issues and resend.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-22 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-21 6:57 [PATCH] drivers: staging: bcm: removed a developer debug message per the TODO list Chuong Ngo
2013-10-22 8:39 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox