From: "Alexander Shiyan" <shc_work@mail.ru>
To: "David Cohen" <david.a.cohen@linux.intel.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz, ning.li@intel.com,
ivan.gorinov@intel.com, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters
Date: Tue, 22 Oct 2013 23:46:00 +0400 [thread overview]
Message-ID: <1382471160.205404749@f402.i.mail.ru> (raw)
In-Reply-To: <1382470930-13807-2-git-send-email-david.a.cohen@linux.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1390 bytes --]
> The change in the max3110 driver makes the IRQ handling threaded, now
> the handler is called only once per received character. Without that
> change, we had many (more than 100) interrupts per one received
> character.
>
> Unfortunately, SFI interface does not support IRQ polarity and
> triggering modes, so we have to keep the hacks as hard-coded device
> names and IRQ numbers until we switch to ACPI.
>
> Edge-triggered IRQ still supported to keep old platforms working.
> Use platform data to pass the irq mode argument.
>
> Signed-off-by: Ivan Gorinov <ivan.gorinov@intel.com>
> Signed-off-by: Li Ning <ning.li@intel.com>
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
...
> +++ b/include/linux/serial_max3110.h
> @@ -0,0 +1,16 @@
> +#ifndef _LINUX_SERIAL_MAX3110_H
> +#define _LINUX_SERIAL_MAX3110_H
> +
> +/**
> + * struct plat_max3110 - MAX3110 SPI UART platform data
> + * @irq_edge_trigger: if IRQ is edge triggered
> + *
> + * You should use this structure in your machine description to specify
> + * how the MAX3110 is connected.
> + *
> + */
> +struct plat_max3110 {
> + int irq_edge_triggered;
> +};
> +
> +#endif
> --
Is just resource->flags for IRQ can be reused for handle such case?
---
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2013-10-22 19:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-22 19:42 [PATCH 1/2] mrst_max3110: fix unbalanced IRQ issue during resume David Cohen
2013-10-22 19:42 ` [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters David Cohen
2013-10-22 19:46 ` Alexander Shiyan [this message]
2013-10-22 20:30 ` David Cohen
2013-10-22 23:02 ` David Cohen
2013-10-23 6:27 ` Alexander Shiyan
2013-10-23 18:10 ` David Cohen
2013-10-23 18:21 ` Felipe Balbi
2013-10-23 18:23 ` Felipe Balbi
2013-10-23 18:38 ` David Cohen
2013-10-23 18:33 ` David Cohen
2013-10-23 18:33 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382471160.205404749@f402.i.mail.ru \
--to=shc_work@mail.ru \
--cc=david.a.cohen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.gorinov@intel.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ning.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox