From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH v4 1/4] usb: gadget: move bitflags to the end of usb_gadget struct
Date: Mon, 4 Nov 2013 14:12:54 -0800 [thread overview]
Message-ID: <1383603177-4624-2-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1383603177-4624-1-git-send-email-david.a.cohen@linux.intel.com>
This patch moves all bitflags to the end of usb_gadget struct in order
to improve readability.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
---
include/linux/usb/gadget.h | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 942ef5e053bf..23b3bfd0a842 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -485,6 +485,11 @@ struct usb_gadget_ops {
* @max_speed: Maximal speed the UDC can handle. UDC must support this
* and all slower speeds.
* @state: the state we are now (attached, suspended, configured, etc)
+ * @name: Identifies the controller hardware type. Used in diagnostics
+ * and sometimes configuration.
+ * @dev: Driver model state for this abstract device.
+ * @out_epnum: last used out ep number
+ * @in_epnum: last used in ep number
* @sg_supported: true if we can handle scatter-gather
* @is_otg: True if the USB device port uses a Mini-AB jack, so that the
* gadget driver must provide a USB OTG descriptor.
@@ -497,11 +502,6 @@ struct usb_gadget_ops {
* only supports HNP on a different root port.
* @b_hnp_enable: OTG device feature flag, indicating that the A-Host
* enabled HNP support.
- * @name: Identifies the controller hardware type. Used in diagnostics
- * and sometimes configuration.
- * @dev: Driver model state for this abstract device.
- * @out_epnum: last used out ep number
- * @in_epnum: last used in ep number
*
* Gadgets have a mostly-portable "gadget driver" implementing device
* functions, handling all usb configurations and interfaces. Gadget
@@ -530,16 +530,17 @@ struct usb_gadget {
enum usb_device_speed speed;
enum usb_device_speed max_speed;
enum usb_device_state state;
+ const char *name;
+ struct device dev;
+ unsigned out_epnum;
+ unsigned in_epnum;
+
unsigned sg_supported:1;
unsigned is_otg:1;
unsigned is_a_peripheral:1;
unsigned b_hnp_enable:1;
unsigned a_hnp_support:1;
unsigned a_alt_hnp_support:1;
- const char *name;
- struct device dev;
- unsigned out_epnum;
- unsigned in_epnum;
};
#define work_to_gadget(w) (container_of((w), struct usb_gadget, work))
--
1.8.4.rc3
next prev parent reply other threads:[~2013-11-04 22:08 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 22:12 [PATCH v4 0/4] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-11-04 22:12 ` David Cohen [this message]
2013-11-04 22:12 ` [PATCH v4 2/4] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget David Cohen
2013-11-05 14:50 ` Alan Stern
2013-11-05 15:08 ` David Cohen
2013-11-05 15:11 ` David Cohen
2013-11-05 15:41 ` Alan Stern
2013-11-05 18:13 ` David Cohen
2013-11-05 21:54 ` David Cohen
2013-11-05 23:45 ` [PATCH v4.1 " David Cohen
2013-11-06 16:06 ` Alan Stern
2013-11-04 22:12 ` [PATCH v4 3/4] usb: ffs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-11-05 14:52 ` Alan Stern
2013-11-05 15:05 ` David Cohen
2013-11-05 15:38 ` Alan Stern
2013-11-05 18:12 ` David Cohen
2013-11-05 18:24 ` Alan Stern
2013-11-06 18:43 ` Michal Nazarewicz
2013-11-07 16:05 ` Alan Stern
2013-11-08 12:23 ` Michal Nazarewicz
2013-11-08 18:04 ` David Cohen
2013-11-05 15:15 ` Cohen, David A
2013-11-10 16:50 ` [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function Michal Nazarewicz
2013-11-10 16:50 ` [PATCH 2/2] check quirk to pad epout buf size when not aligned to maxpacketsize Michal Nazarewicz
2013-11-11 4:01 ` David Cohen
2013-11-11 11:21 ` [PATCHv2 " Michal Nazarewicz
2013-11-11 19:12 ` David Cohen
2013-11-11 21:12 ` Michal Nazarewicz
2013-11-11 20:20 ` Alan Stern
2013-11-11 21:09 ` Michal Nazarewicz
2013-11-11 22:25 ` David Cohen
2013-11-12 15:50 ` Alan Stern
2013-11-12 18:24 ` David Cohen
2013-11-12 23:09 ` Paul Zimmerman
2013-11-12 23:43 ` David Cohen
2013-11-13 0:24 ` Paul Zimmerman
2013-11-13 15:52 ` Alan Stern
2013-11-13 21:51 ` David Cohen
2013-11-21 18:29 ` David Cohen
2013-11-11 23:15 ` David Cohen
2013-11-11 20:07 ` [PATCH 1/2] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-11-11 21:13 ` Michal Nazarewicz
2013-11-11 23:11 ` David Cohen
2013-11-04 22:12 ` [PATCH v4 4/4] usb: dwc3: add quirk USB_GADGET_QUIRK_EP_OUT_ALIGNED_SIZE to gadget driver David Cohen
2013-11-04 22:17 ` [PATCH v4.1 4/4] usb: dwc3: set gadget's quirk ep_out_align_size David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383603177-4624-2-git-send-email-david.a.cohen@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).