From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 05/10] perf list: Add usage
Date: Tue, 5 Nov 2013 17:09:56 -0300 [thread overview]
Message-ID: <1383682201-19399-6-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1383682201-19399-1-git-send-email-acme@infradead.org>
From: David Ahern <dsahern@gmail.com>
Currently 'perf list' is not very helpful if you forget the syntax:
$ perf list -h
List of pre-defined events (to be used in -e):
After:
$ perf list -h
usage: perf list [hw|sw|cache|tracepoint|pmu|event_glob]
Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/527133AD.4030003@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-list.c | 17 ++++++++++++++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
index 45000e7d4398..011195e38f21 100644
--- a/tools/perf/builtin-list.c
+++ b/tools/perf/builtin-list.c
@@ -14,20 +14,31 @@
#include "util/parse-events.h"
#include "util/cache.h"
#include "util/pmu.h"
+#include "util/parse-options.h"
int cmd_list(int argc, const char **argv, const char *prefix __maybe_unused)
{
int i;
+ const struct option list_options[] = {
+ OPT_END()
+ };
+ const char * const list_usage[] = {
+ "perf list [hw|sw|cache|tracepoint|pmu|event_glob]",
+ NULL
+ };
+
+ argc = parse_options(argc, argv, list_options, list_usage,
+ PARSE_OPT_STOP_AT_NON_OPTION);
setup_pager();
- if (argc == 1) {
+ if (argc == 0) {
print_events(NULL, false);
return 0;
}
- for (i = 1; i < argc; ++i) {
- if (i > 2)
+ for (i = 0; i < argc; ++i) {
+ if (i)
putchar('\n');
if (strncmp(argv[i], "tracepoint", 10) == 0)
print_tracepoint_events(NULL, NULL, false);
--
1.8.1.4
next prev parent reply other threads:[~2013-11-05 20:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-05 20:09 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-11-05 20:09 ` [PATCH 01/10] perf hists: Consolidate __hists__add_*entry() Arnaldo Carvalho de Melo
2013-11-05 21:52 ` Rodrigo Campos
2013-11-06 8:16 ` Namhyung Kim
2013-11-06 8:28 ` Rodrigo Campos
2013-11-06 13:42 ` Arnaldo Carvalho de Melo
2013-11-07 6:44 ` Namhyung Kim
2013-11-05 20:09 ` [PATCH 02/10] perf kvm: Disable live command if timerfd is not supported Arnaldo Carvalho de Melo
2013-11-05 20:09 ` [PATCH 03/10] tools/perf/build: Fix detection of non-core features Arnaldo Carvalho de Melo
2013-11-05 20:09 ` [PATCH 04/10] perf list: Remove a level of indentation Arnaldo Carvalho de Melo
2013-11-05 20:09 ` Arnaldo Carvalho de Melo [this message]
2013-11-05 20:09 ` [PATCH 06/10] perf tools: Factor sysfs code into generic fs object Arnaldo Carvalho de Melo
2013-11-05 20:09 ` [PATCH 07/10] perf fs: Rename NAME_find_mountpoint() to NAME__mountpoint() Arnaldo Carvalho de Melo
2013-11-05 20:09 ` [PATCH 08/10] perf fs: Add procfs support Arnaldo Carvalho de Melo
2013-11-05 20:10 ` [PATCH 09/10] perf tools: Check maximum frequency rate for record/top Arnaldo Carvalho de Melo
2013-11-05 20:10 ` [PATCH 10/10] perf tools: Finish the removal of 'self' arguments Arnaldo Carvalho de Melo
2013-11-06 5:31 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383682201-19399-6-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).