From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Rodrigo Campos <rodrigo@sdfg.com.ar>,
Ingo Molnar <mingo@redhat.com>, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 7/7] perf tools: Remove unneeded include
Date: Thu, 7 Nov 2013 12:04:18 -0300 [thread overview]
Message-ID: <1383836658-10518-8-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1383836658-10518-1-git-send-email-acme@infradead.org>
From: Rodrigo Campos <rodrigo@sdfg.com.ar>
There is no point in sort.h including itself.
The include was added when the file was created, in commit "perf tools:
Create util/sort.and use it" (dd68ada2d) and added a include to "sort.h"
in lot of files (all the files that started using the file). It was
probably added by mistake on sort.h too.
Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1383776454-10595-1-git-send-email-rodrigo@sdfg.com.ar
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/sort.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/perf/util/sort.h b/tools/perf/util/sort.h
index f4cc147e0220..43e5ff42a609 100644
--- a/tools/perf/util/sort.h
+++ b/tools/perf/util/sort.h
@@ -22,7 +22,6 @@
#include "parse-events.h"
#include "thread.h"
-#include "sort.h"
extern regex_t parent_regex;
extern const char *sort_order;
--
1.8.1.4
next prev parent reply other threads:[~2013-11-07 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 15:04 [GIT PULL 0/7] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 1/7] perf evsel: Ditch evsel->handler.data field Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 2/7] perf tools: Fix version when building out of tree Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 3/7] perf trace: Don't relookup fields by name in each sample Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 4/7] perf record: Refactor feature handling into a separate function Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 5/7] perf record: Remove advance_output function Arnaldo Carvalho de Melo
2013-11-07 15:04 ` [PATCH 6/7] perf record: Remove post_processing_offset variable Arnaldo Carvalho de Melo
2013-11-07 15:04 ` Arnaldo Carvalho de Melo [this message]
2013-11-07 15:26 ` [GIT PULL 0/7] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383836658-10518-8-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rodrigo@sdfg.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).