linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: cw00.choi@samsung.com
Cc: myungjoo.ham@samsung.com, sameo@linux.intel.com,
	lee.jones@linaro.org, patches@opensource.wolfsonmicro.com,
	linux-kernel@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: [PATCH 3/4] extcon: arizona: Fix race with microphone detection and removal
Date: Fri,  8 Nov 2013 13:19:42 +0000	[thread overview]
Message-ID: <1383916783-17921-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1383916783-17921-1-git-send-email-ckeepax@opensource.wolfsonmicro.com>

The microphone detection code is run as delayed work to provide
additional debounce, it is possible that the jack could have been
removed by the time we process the microphone detection. Turn this
case into a no op.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/extcon/extcon-arizona.c |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)

diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c
index cce24de..0d70bf6 100644
--- a/drivers/extcon/extcon-arizona.c
+++ b/drivers/extcon/extcon-arizona.c
@@ -782,6 +782,19 @@ static void arizona_micd_detect(struct work_struct *work)
 
 	mutex_lock(&info->lock);
 
+	/* If the cable was removed while measuring ignore the result */
+	ret = extcon_get_cable_state_(&info->edev, ARIZONA_CABLE_MECHANICAL);
+	if (ret < 0) {
+		dev_err(arizona->dev, "Failed to check cable state: %d\n",
+				ret);
+		mutex_unlock(&info->lock);
+		return;
+	} else if (!ret) {
+		dev_dbg(arizona->dev, "Ignoring MICDET for removed cable\n");
+		mutex_unlock(&info->lock);
+		return;
+	}
+
 	for (i = 0; i < 10 && !(val & MICD_LVL_0_TO_8); i++) {
 		ret = regmap_read(arizona->regmap, ARIZONA_MIC_DETECT_3, &val);
 		if (ret != 0) {
-- 
1.7.2.5


  parent reply	other threads:[~2013-11-08 13:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-08 13:19 [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels Charles Keepax
2013-11-08 13:19 ` [PATCH 2/4] extcon: arizona: Fix reset of HPDET after race with removal Charles Keepax
2013-11-08 13:19 ` Charles Keepax [this message]
2013-11-08 13:19 ` [PATCH 4/4] extcon: arizona: Eliminate dead error handling code Charles Keepax
2013-11-11  9:00   ` Lee Jones
2013-11-11  9:22     ` Charles Keepax
2013-11-12  0:15   ` Chanwoo Choi
2013-11-12 14:30     ` Charles Keepax
2013-11-13  2:10       ` Chanwoo Choi
2013-11-11 10:00 ` [PATCH 1/4] extcon: arizona: Add defines for microphone detection levels Chanwoo Choi
2013-11-11 10:53   ` Lee Jones
2013-11-11 10:57     ` Chanwoo Choi
2013-11-11 11:19       ` Lee Jones
2013-11-12  0:00         ` Chanwoo Choi
2013-11-11 11:06     ` Charles Keepax
2013-11-11 11:15       ` Lee Jones
2013-11-11 11:22         ` Chanwoo Choi
2013-11-11 11:26           ` Lee Jones
2013-11-12 14:25             ` Charles Keepax
2013-11-12 15:37               ` Lee Jones
2013-11-11 11:29 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383916783-17921-3-git-send-email-ckeepax@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=cw00.choi@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).