From: David Cohen <david.a.cohen@linux.intel.com>
To: balbi@ti.com, gregkh@linuxfoundation.org
Cc: stern@rowland.harvard.edu, mina86@mina86.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
David Cohen <david.a.cohen@linux.intel.com>
Subject: [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget
Date: Mon, 11 Nov 2013 12:16:48 -0800 [thread overview]
Message-ID: <1384201011-11114-3-git-send-email-david.a.cohen@linux.intel.com> (raw)
In-Reply-To: <1384201011-11114-1-git-send-email-david.a.cohen@linux.intel.com>
Due to USB controllers may have different restrictions, usb gadget layer
needs to provide a generic way to inform gadget functions to complain
with non-standard requirements.
This patch adds 'quirk_ep_out_aligned_size' field to struct usb_gadget
to inform when controller's epout requires buffer size to be aligned to
MaxPacketSize. A helper is also provided to align buffer size when
necessary.
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
Michal,
I added prefix 'usb: f_fs: ' to patch's subject. I did not add 'usb: gadget:
f_fs' due to it would be too long.
include/linux/usb/gadget.h | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
index 23b3bfd0a842..41e8834af57d 100644
--- a/include/linux/usb/gadget.h
+++ b/include/linux/usb/gadget.h
@@ -441,6 +441,19 @@ static inline void usb_ep_fifo_flush(struct usb_ep *ep)
ep->ops->fifo_flush(ep);
}
+/**
+ * usb_ep_align_maxpacketsize - returns @len aligned to ep's maxpacketsize
+ * @ep: the endpoint whose maxpacketsize is used to align @len
+ * @len: buffer size's length to align to @ep's maxpacketsize
+ *
+ * This helper is used in case it's required for any reason to align buffer's
+ * size to an ep's maxpacketsize.
+ */
+static inline size_t usb_ep_align_maxpacketsize(struct usb_ep *ep, size_t len)
+{
+ return round_up(len, (size_t)ep->desc->wMaxPacketSize);
+}
+
/*-------------------------------------------------------------------------*/
@@ -502,6 +515,8 @@ struct usb_gadget_ops {
* only supports HNP on a different root port.
* @b_hnp_enable: OTG device feature flag, indicating that the A-Host
* enabled HNP support.
+ * @quirk_ep_out_aligned_size: epout requires buffer size to be aligned to
+ * MaxPacketSize.
*
* Gadgets have a mostly-portable "gadget driver" implementing device
* functions, handling all usb configurations and interfaces. Gadget
@@ -541,6 +556,7 @@ struct usb_gadget {
unsigned b_hnp_enable:1;
unsigned a_hnp_support:1;
unsigned a_alt_hnp_support:1;
+ unsigned quirk_ep_out_aligned_size:1;
};
#define work_to_gadget(w) (container_of((w), struct usb_gadget, work))
--
1.8.4.rc3
next prev parent reply other threads:[~2013-11-11 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-11 20:16 [PATCH v5 0/5] add gadget quirk to adapt f_fs for DWC3 David Cohen
2013-11-11 20:16 ` [PATCH v5 1/5] usb: gadget: move bitflags to the end of usb_gadget struct David Cohen
2013-11-11 23:52 ` Michal Nazarewicz
2013-11-11 20:16 ` David Cohen [this message]
2013-11-11 23:55 ` [PATCH v5 2/5] usb: gadget: add quirk_ep_out_aligned_size field to struct usb_gadget Michal Nazarewicz
2013-11-12 0:03 ` David Cohen
2013-11-12 12:54 ` Michal Nazarewicz
2013-12-06 20:13 ` Felipe Balbi
2013-12-06 20:14 ` David Cohen
2013-11-11 20:16 ` [PATCH v5 3/5] usb: gadget: f_fs: remove loop from I/O function David Cohen
2013-11-11 23:21 ` David Cohen
2013-11-11 23:57 ` [PATCHv5.1 " Michal Nazarewicz
2013-12-06 20:18 ` Felipe Balbi
2013-11-11 20:16 ` [PATCH v5 4/5] usb: f_fs: check quirk to pad epout buf size when not aligned to maxpacketsize David Cohen
2013-11-11 23:58 ` [PATCHv5.1 4/5] " Michal Nazarewicz
2013-11-12 0:12 ` David Cohen
2013-11-12 12:59 ` Michal Nazarewicz
2013-11-12 18:26 ` David Cohen
2013-12-06 20:19 ` Felipe Balbi
2013-11-11 20:16 ` [PATCH v5 5/5] usb: dwc3: set gadget's quirk ep_out_align_size David Cohen
2013-12-06 20:19 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384201011-11114-3-git-send-email-david.a.cohen@linux.intel.com \
--to=david.a.cohen@linux.intel.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).