public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alexandre Demers <alexandre.f.demers@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, linux-kernel@vger.kernel.org
Subject: [PATCH] Silence r8712u info and add verbose option v2
Date: Tue, 12 Nov 2013 13:43:13 -0500	[thread overview]
Message-ID: <1384281793-4733-1-git-send-email-alexandre.f.demers@gmail.com> (raw)

r8712u pollutes dmesg and logs. Silence it and add a verbose option to KConfig if we ever 
really want to hear about it.

v2: keep netdev_info instead of replacing it by a KERN_NOTICE

---
 drivers/staging/rtl8712/Kconfig        | 7 +++++++
 drivers/staging/rtl8712/rtl871x_mlme.c | 7 ++++---
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8712/Kconfig b/drivers/staging/rtl8712/Kconfig
index 6a43312..7cae8f8 100644
--- a/drivers/staging/rtl8712/Kconfig
+++ b/drivers/staging/rtl8712/Kconfig
@@ -16,4 +16,11 @@ config R8712_TX_AGGR
 	---help---
 	This option provides transmit aggregation for the Realtek RTL8712 USB device.
 
+config R8712U_DEBUG
+	bool "Realtek RTL8712U Wireless verbose debug"
+	depends on R8712U
+	help
+	  Say Y here in order to have the rtl8712u code generate
+	  verbose debugging messages.
+
 
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 6596154..1226009 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -1043,9 +1043,12 @@ void r8712_got_addbareq_event_callback(struct _adapter *adapter, u8 *pbuf)
 	struct	sta_priv *pstapriv = &adapter->stapriv;
 	struct	recv_reorder_ctrl *precvreorder_ctrl = NULL;
 
+#ifdef CONFIG_R8712U_DEBUG
	netdev_info(adapter->pnetdev, "%s: mac = %pM, seq = %d, tid = %d\n",
		    __func__, pAddbareq_pram->MacAddress,
	    pAddbareq_pram->StartSeqNum, pAddbareq_pram->tid);
+#endif
+
 	psta = r8712_get_stainfo(pstapriv, pAddbareq_pram->MacAddress);
 	if (psta) {
 		precvreorder_ctrl =
-- 
1.8.4.2


             reply	other threads:[~2013-11-12 18:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-12 18:43 Alexandre Demers [this message]
2013-11-12 19:14 ` [PATCH] Silence r8712u info and add verbose option v2 Larry Finger
2013-11-12 21:06   ` Greg Kroah-Hartman
2013-11-12 22:38     ` Alexandre Demers
2013-11-12 23:28       ` Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384281793-4733-1-git-send-email-alexandre.f.demers@gmail.com \
    --to=alexandre.f.demers@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox