From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Jiri Olsa <jolsa@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 08/13] perf record: Fix segfault with --no-mmap-pages
Date: Tue, 12 Nov 2013 17:46:13 -0300 [thread overview]
Message-ID: <1384289178-31374-9-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1384289178-31374-1-git-send-email-acme@infradead.org>
From: David Ahern <dsahern@gmail.com>
Adrian reported a segfault when using --no-out-pages:
$ tools/perf/perf record -vv --no-out-pages uname
Segmentation fault (core dumped)
The same occurs with --no-mmap-pages. Fix by checking that str is
non-NULL before parsing it.
Signed-off-by: David Ahern <dsahern@gmail.com>
Reported-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Link: http://lkml.kernel.org/r/1384267617-3446-2-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evlist.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 99dc58e5dcc3..3960560f873a 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -719,6 +719,9 @@ int perf_evlist__parse_mmap_pages(const struct option *opt, const char *str,
{ .tag = 0 },
};
+ if (str == NULL)
+ return -1;
+
val = parse_tag_value(str, tags);
if (val != (unsigned long) -1) {
/* we got file size value */
--
1.8.1.4
next prev parent reply other threads:[~2013-11-12 20:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-12 20:46 [GIT PULL 00/13] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 01/13] perf trace: Beautify fifth argument of mmap() as fd Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 02/13] perf trace: Separate tp syscall field caching into init routine to be reused Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 03/13] perf trace: Fix segfault on perf trace -i perf.data Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 04/13] perf tests: Compensate lower sample freq with longer test loop Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 05/13] perf trace: Change syscall summary duration order Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 06/13] perf trace: Simplify '--summary' output Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 07/13] perf trace: Add summary only option Arnaldo Carvalho de Melo
2013-11-12 20:46 ` Arnaldo Carvalho de Melo [this message]
2013-11-12 20:46 ` [PATCH 09/13] perf evlist: Round mmap pages to power 2 - v2 Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 10/13] perf evlist: Refactor mmap_pages parsing Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 11/13] perf tests: Handle throttle events in 'object code reading' test Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 12/13] perf target: Shorten perf_target__ to target__ Arnaldo Carvalho de Melo
2013-11-12 20:46 ` [PATCH 13/13] tools lib traceevent: Add direct access to dynamic arrays Arnaldo Carvalho de Melo
2013-11-12 20:50 ` [GIT PULL 00/13] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384289178-31374-9-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).