linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Clement Chauplannaz <chauplac@gmail.com>
To: linux-kbuild@vger.kernel.org
Cc: yann.morin.1998@free.fr, mmarek@suse.cz, sedat.dilek@gmail.com,
	linus.walleij@linaro.org, linux-kernel@vger.kernel.org
Subject: [PATCH] scripts/config: allow setting a string which value contains a colon
Date: Sun, 17 Nov 2013 12:55:34 +0100	[thread overview]
Message-ID: <1384689334-6979-1-git-send-email-chauplac@gmail.com> (raw)

A bug in script `config' prevented from modifying an existing variable's
value to a string that contains a colon ':'.  The reason behind it is that
colons are used as a separator in `sed' commands that script `config'
relies on.

Escape colons in `sed' commands to allow values containing colons.

Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>
---
 scripts/config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/config b/scripts/config
index 6804179..4b16260 100755
--- a/scripts/config
+++ b/scripts/config
@@ -78,7 +78,7 @@ txt_append() {
 
 txt_subst() {
 	local before="$1"
-	local after="$2"
+	local after="${2//:/\:}"
 	local infile="$3"
 	local tmpfile="$infile.swp"
 
-- 
1.8.3.2.dirty


             reply	other threads:[~2013-11-17 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-17 11:55 Clement Chauplannaz [this message]
2013-11-18 18:06 ` [PATCH] scripts/config: allow setting a string which value contains a colon Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384689334-6979-1-git-send-email-chauplac@gmail.com \
    --to=chauplac@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=sedat.dilek@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).