* [PATCH] scripts/config: allow setting a string which value contains a colon
@ 2013-11-17 11:55 Clement Chauplannaz
2013-11-18 18:06 ` Yann E. MORIN
0 siblings, 1 reply; 2+ messages in thread
From: Clement Chauplannaz @ 2013-11-17 11:55 UTC (permalink / raw)
To: linux-kbuild
Cc: yann.morin.1998, mmarek, sedat.dilek, linus.walleij, linux-kernel
A bug in script `config' prevented from modifying an existing variable's
value to a string that contains a colon ':'. The reason behind it is that
colons are used as a separator in `sed' commands that script `config'
relies on.
Escape colons in `sed' commands to allow values containing colons.
Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>
---
scripts/config | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/config b/scripts/config
index 6804179..4b16260 100755
--- a/scripts/config
+++ b/scripts/config
@@ -78,7 +78,7 @@ txt_append() {
txt_subst() {
local before="$1"
- local after="$2"
+ local after="${2//:/\:}"
local infile="$3"
local tmpfile="$infile.swp"
--
1.8.3.2.dirty
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] scripts/config: allow setting a string which value contains a colon
2013-11-17 11:55 [PATCH] scripts/config: allow setting a string which value contains a colon Clement Chauplannaz
@ 2013-11-18 18:06 ` Yann E. MORIN
0 siblings, 0 replies; 2+ messages in thread
From: Yann E. MORIN @ 2013-11-18 18:06 UTC (permalink / raw)
To: Clement Chauplannaz
Cc: linux-kbuild, mmarek, sedat.dilek, linus.walleij, linux-kernel
Clément, All,
On 2013-11-17 12:55 +0100, Clement Chauplannaz spake thusly:
> A bug in script `config' prevented from modifying an existing variable's
> value to a string that contains a colon ':'. The reason behind it is that
> colons are used as a separator in `sed' commands that script `config'
> relies on.
>
> Escape colons in `sed' commands to allow values containing colons.
>
> Signed-off-by: Clement Chauplannaz <chauplac@gmail.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
It'll be in my tree soon, as a rc-fix. Thank you.
Regards,
Yann E. MORIN.
> ---
> scripts/config | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/config b/scripts/config
> index 6804179..4b16260 100755
> --- a/scripts/config
> +++ b/scripts/config
> @@ -78,7 +78,7 @@ txt_append() {
>
> txt_subst() {
> local before="$1"
> - local after="$2"
> + local after="${2//:/\:}"
> local infile="$3"
> local tmpfile="$infile.swp"
>
> --
> 1.8.3.2.dirty
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-18 18:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-17 11:55 [PATCH] scripts/config: allow setting a string which value contains a colon Clement Chauplannaz
2013-11-18 18:06 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).