From: Andi Shyti <andi@etezian.org>
To: m.chehab@samsung.com, mkrufky@linuxtv.org, ljalvs@gmail.com,
crope@iki.fi
Cc: andi@etezian.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] media: cx24117: use a valid dev pointer for dev_err printout
Date: Tue, 19 Nov 2013 15:11:58 +0100 [thread overview]
Message-ID: <1384870318-27768-1-git-send-email-andi@etezian.org> (raw)
In-Reply-To: <1384868977-24211-1-git-send-email-andi@etezian.org>
Don't use '&state->priv->i2c->dev' reference to device because
state is still 'NULL'. Use '&i2c->dev' instead.
This bug has been reported by scan.coverity.com
Signed-off-by: Andi Shyti <andi@etezian.org>
---
Hi,
please apply this patch after my previous patch, forgot to
format them together.
Thanks,
Andi
---
drivers/media/dvb-frontends/cx24117.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/cx24117.c b/drivers/media/dvb-frontends/cx24117.c
index 07a9894..083830b 100644
--- a/drivers/media/dvb-frontends/cx24117.c
+++ b/drivers/media/dvb-frontends/cx24117.c
@@ -1166,7 +1166,7 @@ struct dvb_frontend *cx24117_attach(const struct cx24117_config *config,
switch (demod) {
case 0:
- dev_err(&state->priv->i2c->dev,
+ dev_err(&i2c->dev,
"%s: Error attaching frontend %d\n",
KBUILD_MODNAME, demod);
goto error1;
--
1.8.4.3
prev parent reply other threads:[~2013-11-19 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-19 13:49 [PATCH] media: cx24117: remove dead code in always 'false' if statement Andi Shyti
2013-11-19 14:11 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384870318-27768-1-git-send-email-andi@etezian.org \
--to=andi@etezian.org \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=ljalvs@gmail.com \
--cc=m.chehab@samsung.com \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).