From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754436Ab3KTWni (ORCPT ); Wed, 20 Nov 2013 17:43:38 -0500 Received: from g1t0028.austin.hp.com ([15.216.28.35]:16387 "EHLO g1t0028.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751918Ab3KTWng (ORCPT ); Wed, 20 Nov 2013 17:43:36 -0500 Message-ID: <1384987135.1791.153.camel@misato.fc.hp.com> Subject: Re: [PATCH] sysfs, acpi, tables: Set file size for each ACPI table From: Toshi Kani To: HATAYAMA Daisuke Cc: lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, Linux Kernel Mailing List Date: Wed, 20 Nov 2013 15:38:55 -0700 In-Reply-To: <528B2757.6010406@jp.fujitsu.com> References: <528B2757.6010406@jp.fujitsu.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-11-19 at 17:54 +0900, HATAYAMA Daisuke wrote: > Currently, each of the ACPI tables exported from > /sys/firmware/acpi/tables is of zero size: > > $ LANG=C ls -ld /sys/firmware/acpi/tables/* > -r-------- 1 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/APIC > -r-------- 1 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/BOOT > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/DSDT > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/FACP > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/FACS > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/MCFG > -r-------- 1 root root 0 Nov 19 14:25 /sys/firmware/acpi/tables/SRAT > drwxr-xr-x 2 root root 0 Nov 19 09:48 /sys/firmware/acpi/tables/dynamic/ > > due to which, user-land tools fail reading each table. For example: > > $ acpidump -f /sys/firmware/acpi/tables/SRAT > Could not get input file size: /sys/firmware/acpi/tables/SRAT > > To deal with the issue, this patch assigns size of each ACPI table to > the corresponding sysfs file. > > $ LANG=C ls -hld /sys/firmware/acpi/tables/* > -r-------- 1 root root 94 Nov 19 16:45 /sys/firmware/acpi/tables/APIC > -r-------- 1 root root 40 Nov 19 16:45 /sys/firmware/acpi/tables/BOOT > -r-------- 1 root root 58K Nov 19 16:55 /sys/firmware/acpi/tables/DSDT > -r-------- 1 root root 244 Nov 19 16:55 /sys/firmware/acpi/tables/FACP > -r-------- 1 root root 64 Nov 19 16:55 /sys/firmware/acpi/tables/FACS > -r-------- 1 root root 60 Nov 19 16:55 /sys/firmware/acpi/tables/MCFG > -r-------- 1 root root 168 Nov 19 16:45 /sys/firmware/acpi/tables/SRAT > drwxr-xr-x 2 root root 0 Nov 19 16:55 /sys/firmware/acpi/tables/dynamic/ > > Then, user-land tools work well like: > > $ acpidump -f /sys/firmware/acpi/tables/SRAT > SRAT @ 0x0000000000000000 > 0000: 53 52 41 54 A8 00 00 00 02 65 56 4D 57 41 52 45 SRAT.....eVMWARE > 0010: 4D 45 4D 50 4C 55 47 20 00 00 04 06 56 4D 57 20 MEMPLUG ....VMW > 0020: 01 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ > 0030: 01 28 00 00 00 00 00 00 00 00 00 00 00 00 00 00 .(.............. > 0040: 00 00 0A 00 00 00 00 00 00 00 00 00 01 00 00 00 ................ > 0050: 00 00 00 00 00 00 00 00 01 28 00 00 00 00 00 00 .........(...... > 0060: 00 00 10 00 00 00 00 00 00 00 F0 BF 00 00 00 00 ................ > 0070: 00 00 00 00 01 00 00 00 00 00 00 00 00 00 00 00 ................ > 0080: 01 28 00 00 00 00 00 00 00 00 00 00 01 00 00 00 .(.............. > 0090: 00 00 00 40 00 00 00 00 00 00 00 00 01 00 00 00 ...@............ > 00A0: 00 00 00 00 00 00 00 00 ........ > > Signed-off-by: HATAYAMA Daisuke Acked-by: Toshi Kani Thanks, -Toshi