linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Mason <jon.mason@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@redhat.com>
Subject: [PATCH 3/9] ntb: Fix missed call to pci_enable_msix()
Date: Wed, 20 Nov 2013 17:21:24 -0700	[thread overview]
Message-ID: <1384993290-10107-4-git-send-email-jon.mason@intel.com> (raw)
In-Reply-To: <1384993290-10107-1-git-send-email-jon.mason@intel.com>

From: Alexander Gordeev <agordeev@redhat.com>

Current MSI-X enablement code assumes MSI-Xs were successfully
allocated in case less than requested vectors were available.
That assumption is wrong, since MSI-Xs should be enabled with
a repeated call to pci_enable_msix(). This update fixes this.

Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
Signed-off-by: Jon Mason <jon.mason@intel.com>
---
 drivers/ntb/ntb_hw.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/ntb/ntb_hw.c b/drivers/ntb/ntb_hw.c
index a9b065f..fa97948 100644
--- a/drivers/ntb/ntb_hw.c
+++ b/drivers/ntb/ntb_hw.c
@@ -1084,6 +1084,10 @@ static int ntb_setup_msix(struct ntb_device *ndev)
 			 "Only %d MSI-X vectors.  Limiting the number of queues to that number.\n",
 			 rc);
 		msix_entries = rc;
+
+		rc = pci_enable_msix(pdev, ndev->msix_entries, msix_entries);
+		if (rc)
+			goto err1;
 	}
 
 	for (i = 0; i < msix_entries; i++) {
-- 
1.7.9.5


  parent reply	other threads:[~2013-11-21  0:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  0:21 [PATCH 0/9] NTB Update Jon Mason
2013-11-21  0:21 ` [PATCH 1/9] NTB: Xeon Doorbell errata workaround Jon Mason
2013-11-21  0:21 ` [PATCH 2/9] NTB: Fix NTB-RP Link Up Jon Mason
2013-11-21  0:21 ` Jon Mason [this message]
2013-11-21  0:21 ` [PATCH 4/9] NTB: Fix ntb_transport link down race Jon Mason
2013-11-21  0:21 ` [PATCH 5/9] NTB: correct dmaengine_get/put usage Jon Mason
2013-11-21  0:21 ` [PATCH 6/9] NTB: remove duplicate defines Jon Mason
2013-11-21  0:21 ` [PATCH 7/9] NTB: Document HW errata Jon Mason
2013-11-21  0:21 ` [PATCH 8/9] NTB: Enable Snoop on Primary Side Jon Mason
2013-11-21  0:21 ` [PATCH 9/9] NTB: Disable interrupts and poll under high load Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384993290-10107-4-git-send-email-jon.mason@intel.com \
    --to=jon.mason@intel.com \
    --cc=agordeev@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).