From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linus Walleij <linus.walleij@linaro.org>,
Chris Ball <cjb@laptop.org>,
Johannes Berg <johannes@sipsolutions.net>,
Rhyland Klein <rklein@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Alexandre Courbot <acourbot@nvidia.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Rob Landley <rob@landley.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support
Date: Fri, 22 Nov 2013 14:14:30 +0200 [thread overview]
Message-ID: <1385122474-14926-4-git-send-email-mika.westerberg@linux.intel.com> (raw)
In-Reply-To: <1385122474-14926-1-git-send-email-mika.westerberg@linux.intel.com>
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
All platforms using this driver are now converted to the new
descriptor-based GPIO interface.
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
net/rfkill/rfkill-gpio.c | 61 ++++++++++--------------------------------------
1 file changed, 12 insertions(+), 49 deletions(-)
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 503432154616..bd2a5b90400c 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -68,35 +68,6 @@ static const struct rfkill_ops rfkill_gpio_ops = {
.set_block = rfkill_gpio_set_power,
};
-static int rfkill_gpio_convert_to_desc(struct platform_device *pdev,
- struct rfkill_gpio_data *rfkill)
-{
- struct rfkill_gpio_platform_data *pdata = pdev->dev.platform_data;
- int ret;
-
- if (gpio_is_valid(pdata->reset_gpio)) {
- ret = devm_gpio_request_one(&pdev->dev, pdata->reset_gpio,
- 0, rfkill->reset_name);
- if (ret) {
- dev_err(&pdev->dev, "failed to get reset gpio.\n");
- return ret;
- }
- rfkill->reset_gpio = gpio_to_desc(pdata->reset_gpio);
- }
-
- if (gpio_is_valid(pdata->shutdown_gpio)) {
- ret = devm_gpio_request_one(&pdev->dev, pdata->shutdown_gpio,
- 0, rfkill->shutdown_name);
- if (ret) {
- dev_err(&pdev->dev, "failed to get shutdown gpio.\n");
- return ret;
- }
- rfkill->shutdown_gpio = gpio_to_desc(pdata->shutdown_gpio);
- }
-
- return 0;
-}
-
static int rfkill_gpio_acpi_probe(struct device *dev,
struct rfkill_gpio_data *rfkill)
{
@@ -117,6 +88,7 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
struct rfkill_gpio_platform_data *pdata = pdev->dev.platform_data;
struct rfkill_gpio_data *rfkill;
const char *clk_name = NULL;
+ struct gpio_desc *gpio;
int ret;
int len;
@@ -150,29 +122,20 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
rfkill->clk = devm_clk_get(&pdev->dev, clk_name);
- if (pdata && (pdata->reset_gpio || pdata->shutdown_gpio)) {
- ret = rfkill_gpio_convert_to_desc(pdev, rfkill);
+ gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
+ if (!IS_ERR(gpio)) {
+ ret = gpiod_direction_output(gpio, 0);
if (ret)
return ret;
- } else {
- struct gpio_desc *gpio;
-
- gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0);
- if (!IS_ERR(gpio)) {
- ret = gpiod_direction_output(gpio, 0);
- if (ret)
- return ret;
- rfkill->reset_gpio = gpio;
- }
+ rfkill->reset_gpio = gpio;
+ }
- gpio = devm_gpiod_get_index(&pdev->dev,
- rfkill->shutdown_name, 1);
- if (!IS_ERR(gpio)) {
- ret = gpiod_direction_output(gpio, 0);
- if (ret)
- return ret;
- rfkill->shutdown_gpio = gpio;
- }
+ gpio = devm_gpiod_get_index(&pdev->dev, rfkill->shutdown_name, 1);
+ if (!IS_ERR(gpio)) {
+ ret = gpiod_direction_output(gpio, 0);
+ if (ret)
+ return ret;
+ rfkill->shutdown_gpio = gpio;
}
/* Make sure at-least one of the GPIO is defined and that
--
1.8.4.3
next prev parent reply other threads:[~2013-11-22 12:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 12:14 [PATCH v2 0/7] gpio / ACPI: convert users to gpiod_* and drop acpi_gpio.h Mika Westerberg
2013-11-22 12:14 ` [PATCH v2 1/7] net: rfkill: gpio: convert to descriptor-based GPIO interface Mika Westerberg
2013-11-22 12:14 ` [PATCH v2 2/7] ARM: tegra: add gpiod_lookup table for paz00 Mika Westerberg
2013-11-22 18:40 ` Stephen Warren
2013-11-23 5:36 ` Alexandre Courbot
2013-11-22 12:14 ` Mika Westerberg [this message]
2013-11-22 18:40 ` [PATCH v2 3/7] net: rfkill: gpio: remove gpio conversion support Stephen Warren
2013-11-22 20:56 ` Heikki Krogerus
2013-11-22 21:00 ` Stephen Warren
2013-11-25 8:35 ` Heikki Krogerus
2013-11-23 8:59 ` Alexandre Courbot
2013-11-25 8:41 ` Heikki Krogerus
2013-11-25 8:47 ` Alex Courbot
2013-11-25 9:02 ` Heikki Krogerus
2013-11-25 9:05 ` Alex Courbot
2013-11-22 12:14 ` [PATCH v2 4/7] mmc: sdhci-acpi: covert to use GPIO descriptor API Mika Westerberg
2013-11-22 13:39 ` Adrian Hunter
2013-11-23 9:23 ` Alexandre Courbot
2013-11-22 12:14 ` [PATCH v2 5/7] gpio / ACPI: register to ACPI events automatically Mika Westerberg
2013-11-22 12:14 ` [PATCH v2 6/7] gpio / ACPI: get rid of acpi_gpio.h Mika Westerberg
2013-11-23 9:21 ` Alexandre Courbot
2013-11-25 8:54 ` Mika Westerberg
2013-11-25 8:51 ` Alex Courbot
2013-11-25 10:18 ` Mika Westerberg
2013-11-22 12:14 ` [PATCH v2 7/7] Documentation / ACPI: update to GPIO descriptor API Mika Westerberg
2013-11-22 12:41 ` [PATCH v2 0/7] gpio / ACPI: convert users to gpiod_* and drop acpi_gpio.h Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385122474-14926-4-git-send-email-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=acourbot@nvidia.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=rklein@nvidia.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox