From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755836Ab3KVOdj (ORCPT ); Fri, 22 Nov 2013 09:33:39 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44269 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755724Ab3KVOdh (ORCPT ); Fri, 22 Nov 2013 09:33:37 -0500 Subject: Re: [PATCH 05/22] tools lib traceevent: Add hrtimer plugin From: Namhyung Kim To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo , Steven Rostedt , David Ahern In-Reply-To: <1385031680-9014-6-git-send-email-jolsa@redhat.com> References: <1385031680-9014-1-git-send-email-jolsa@redhat.com> <1385031680-9014-6-git-send-email-jolsa@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 22 Nov 2013 23:33:29 +0900 Message-ID: <1385130809.1747.38.camel@leonhard> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013-11-21 (목), 12:01 +0100, Jiri Olsa: > Backporting hrtimer plugin. > > Backported from Steven Rostedt's trace-cmd repo (HEAD 0f2c2fb): > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/trace-cmd.git > > This plugin adds function field resolving for following > tracepoint events: > timer:hrtimer_expire_entry > timer:hrtimer_start > > The diff of 'perf script' output generated by old and new code: > (data was generated by 'perf record -e 'timer:hrtimer*' -a') > > --- script.hrtimer.old > +++ script.hrtimer.new > - swapper 0 [000] 27405.519092: timer:hrtimer_start: [FAILED TO PARSE] hrtimer=0xffff88021e20e800 function=0xffffffff810c0e10 expires=27398383000000 softexpires=27398383000000 > + swapper 0 [000] 27405.519103: timer:hrtimer_start: hrtimer=0xffff88021e20e800 function=tick_sched_timer expires=27398383000000 softexpires=27398383000000 > - swapper 0 [001] 27405.519544: timer:hrtimer_expire_entry: [FAILED TO PARSE] hrtimer=0xffff880211334058 now=27398294182491 function=0xffffffff81086f20 > + swapper 0 [001] 27405.519544: timer:hrtimer_expire_entry: hrtimer=0xffff880211334058 now=27398294182491 function=posix_timer_fn/0x0 > > Check the 'function' field is translated into the function name. [SNIP] > + if (!fn) { > + trace_seq_printf(s, " function=MISSING"); > + } else { > + unsigned long long function; > + const char *func; > + > + if (pevent_read_number_field(fn, data, &function)) > + trace_seq_printf(s, " function=INVALID"); > + > + func = pevent_find_function(pevent, function); > + > + trace_seq_printf(s, " function=%s", func); Shouldn't it be like below? if (pevent_read_number_field(fn, data, &function)) trace_seq_printf(s, " function=INVALID"); else { func = pevent_find_function(pevent, function); trace_seq_printf(s, " function=%s", func); } Otherwise it'll print "function=XXX" twice if pevent_read_number_field() failed. Thanks, Namhyung > + } > + > + trace_seq_printf(s, " expires="); > + pevent_print_num_field(s, "%llu", event, "expires", record, 1); > + > + trace_seq_printf(s, " softexpires="); > + pevent_print_num_field(s, "%llu", event, "softexpires", record, 1); > + return 0; > +} > + > +int PEVENT_PLUGIN_LOADER(struct pevent *pevent) > +{ > + pevent_register_event_handler(pevent, -1, > + "timer", "hrtimer_expire_entry", > + timer_expire_handler, NULL); > + > + pevent_register_event_handler(pevent, -1, "timer", "hrtimer_start", > + timer_start_handler, NULL); > + return 0; > +}