From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755651Ab3KVPiM (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Nov 2013 10:38:12 -0500
Received: from mail-pa0-f43.google.com ([209.85.220.43]:58888 "EHLO
	mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753034Ab3KVPiK (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Nov 2013 10:38:10 -0500
Subject: Re: [PATCH 18/22] perf tools: Add udis86 disassembler feature check
From: Namhyung Kim <namhyung@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@gmail.com>, Ingo Molnar <mingo@elte.hu>,
        Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>, David Ahern <dsahern@gmail.com>
In-Reply-To: <1385031680-9014-19-git-send-email-jolsa@redhat.com>
References: <1385031680-9014-1-git-send-email-jolsa@redhat.com>
	 <1385031680-9014-19-git-send-email-jolsa@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Sat, 23 Nov 2013 00:38:02 +0900
Message-ID: <1385134682.1747.112.camel@leonhard>
Mime-Version: 1.0
X-Mailer: Evolution 2.28.3
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

2013-11-21 (목), 12:01 +0100, Jiri Olsa:
> Adding udis86 disassembler feature check which support
> is needed for kvm:kvm_emulate_insn tracepoint.
> 
> The diff of 'perf script' output generated by old and new code:
> (data was generated by 'perf record -e kvm:kvm_emulate_insn -a')
> 
> --- script.kvm.old
> +++ script.kvm.new
> - qemu-system-x86 15519 [003]  5332.470049: kvm:kvm_emulate_insn: 0:ffffffff8103c596:89 b7 00 80 5f ff (prot64)
> + qemu-system-x86 15519 [003]  5332.470049: kvm:kvm_emulate_insn: 0:ffffffff8103c596: mov %esi, -0xa08000(%rdi)

[SNIP]
> --- a/tools/perf/Makefile.perf
> +++ b/tools/perf/Makefile.perf
> @@ -710,7 +710,7 @@ $(LIB_FILE): $(LIB_OBJS)
>  # libtraceevent.a
>  TE_SOURCES = $(wildcard $(TRACE_EVENT_DIR)*.[ch])
>  
> -LIBTRACEEVENT_FLAGS=$(QUIET_SUBDIR1) O=$(OUTPUT) CFLAGS="-g -Wall $(EXTRA_CFLAGS)" plugin_dir=$(plugindir_SQ)
> +LIBTRACEEVENT_FLAGS=$(QUIET_SUBDIR1) O=$(OUTPUT) CFLAGS="-g -Wall $(EXTRA_CFLAGS) $(LIBTRACEEVENT_CFLAGS)" plugin_dir=$(plugindir_SQ)

What about breaking the line with "+="?

>  
>  $(LIBTRACEEVENT): $(TE_SOURCES) $(OUTPUT)PERF-CFLAGS
>  	$(QUIET_SUBDIR0)$(TRACE_EVENT_DIR) $(LIBTRACEEVENT_FLAGS) libtraceevent.a plugins
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 8c8a205..3f9c6b4 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -418,6 +418,14 @@ else
>    msg := $(warning No timerfd support. Disables 'perf kvm stat live');
>  endif
>  
> +$(call feature_check,udis86)
> +ifeq ($(feature-udis86), 1)
> +  LIBTRACEEVENT_CFLAGS += -DHAVE_UDIS86
> +  EXTLIBS += -ludis86
> +else
> +  msg := $(warning No udis86 support.);
> +endif

I think we can just use libbfd for this eventually.  But it can be a
later work. :)

Thanks,
Namhyung