From: Peter Hurley <peter@hurleysoftware.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>
Subject: [PATCH staging-next 2/4] staging/fwserial: Up the tty buffer limit to 128K
Date: Fri, 22 Nov 2013 13:06:09 -0500 [thread overview]
Message-ID: <1385143571-3571-3-git-send-email-peter@hurleysoftware.com> (raw)
In-Reply-To: <1385143571-3571-1-git-send-email-peter@hurleysoftware.com>
The firewire driver can overrun the tty buffers before the
line discipline can throttle the input; up the buffer limit.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
drivers/staging/fwserial/fwserial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c
index c96f62e..cad9e3f 100644
--- a/drivers/staging/fwserial/fwserial.c
+++ b/drivers/staging/fwserial/fwserial.c
@@ -2225,6 +2225,7 @@ static int fwserial_create(struct fw_unit *unit)
port->index = FWTTY_INVALID_INDEX;
port->port.ops = &fwtty_port_ops;
port->serial = serial;
+ tty_buffer_set_limit(&port->port, 128 * 1024);
spin_lock_init(&port->lock);
INIT_DELAYED_WORK(&port->drain, fwtty_drain_tx);
--
1.8.1.2
next prev parent reply other threads:[~2013-11-22 18:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 18:06 [PATCH staging-next 0/4] fwserial changes for 3.14 Peter Hurley
2013-11-22 18:06 ` [PATCH staging-next 1/4] staging/fwserial: Rip out rx buffering Peter Hurley
2013-11-22 18:06 ` Peter Hurley [this message]
2013-11-22 18:06 ` [PATCH staging-next 3/4] staging/fwserial: Rename data profiling functions Peter Hurley
2013-11-22 18:06 ` [PATCH staging-next 4/4] staging/fwserial: Add Kconfig options for max ports Peter Hurley
2013-11-25 20:43 ` [PATCH staging-next 0/4] fwserial changes for 3.14 Greg Kroah-Hartman
2013-11-25 21:00 ` Peter Hurley
2013-11-25 21:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385143571-3571-3-git-send-email-peter@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox