Re: [patch 5/9 v3] efi: export more efi table variable to sysfs

Dave Young
2013-11-25T05:30:05Z

On 11/23/13 at 02:15pm, Borislav Petkov wrote:
> On Fri, Nov 22, 2013 at 10:48:50AM +0800, Dave Young wrote:
> > > efi.config_table = (unsigned long)efi.systab->tables;
> > > efi.fw_vendor = (unsigned long)efi.systab->fw_vendor;
> > > efi.runtime = (unsigned long)efi.systab->runtime;
> >
> > Hmm, UEFI spec mentions the them like below so I use the order:
>
> I'm sure by now you know you should not really trust the UEFI spec, or
> any other spec for that matter :)
>
> > Several fields of the EFI System Table must be converted from
> > physical pointers to virtual pointers using the ConvertPointer()
> > service. These fields include FirmwareVendor, RuntimeServices,
> > and ConfigurationTable.
> >
> > But since you like the reverse I can change it in next version.
>
> The reverse was simply a suggestion. The vertical alignment was more
> what I aimed at because it makes this chunk much more readable IMO.
>

Got your point about alignment, will update.

--
Thanks
Dave