Re: [patch 5/9 v3] efi: export more efi table variable to sysfs

Dave Young
2013-11-22T02:52:38Z

> > +
> > + if (efi.config_table != EFI_INVALID_TABLE_ADDR) {
> > + error = sysfs_create_file(efi_kobj,
> > + &efi_attr_config_table.attr);
> > + if (error) {
> > + pr_err("efi: Sysfs attribute %s export failed with error %d.\n",
> > + efi_attr_config_table.attr.name, error);
> > + goto err_remove_runtime;
> > + }
> > + }
>
> You don't need to do this "if SOMETHING then create the file", just use
> the "is_visible" attribute in the group to do this as a callback to
> determine this when the group is registered.

I did not know the is_visible before, thanks for the hint, will use it

--
Thanks for review
Dave