Re: [PATCH v4 09/41] sysfs, kernfs: introduce kernfs_create_dir[_ns]()

Greg KH
2013-11-28T06:04:31Z

On Sat, Nov 23, 2013 at 06:07:04PM -0500, Tejun Heo wrote:
> Introduce kernfs interface to manipulate a directory which takes and
> returns sysfs_dirents.
>
> create_dir() is renamed to kernfs_create_dir_ns() and its argumantes
> and return value are updated. create_dir() usages are replaced with
> kernfs_create_dir_ns() and sysfs_create_subdir() usages are replaced
> with kernfs_create_dir(). Dup warnings are handled explicitly by
> sysfs users of the kernfs interface.
>
> sysfs_enable_ns() is renamed to kernfs_enable_ns().
>
> This patch doesn't introduce any behavior changes.
>
> v2: Dummy implementation for !CONFIG_SYSFS updated to return -ENOSYS.
>
> v3: kernfs_enable_ns() added.
>
> v4: Refreshed on top of "sysfs: drop kobj_ns_type handling, take #2"
> so that this patch removes sysfs_enable_ns().

Care to go for v5? This doesn't apply on my tree anymore, I'm pretty
sure due to the other fixes in fs/sysfs/dir.c.

I tried to do the merge myself, but I don't think I got it right at all,
so could you just check out my driver-core.git tree on the
driver-core-next branch and refresh this patch?

thanks so much, I've applied the other 8 patches in this series already,
they seem fine.

greg k-h