Re: [PATCH 14/24] avr32: Use Kbuild logic to provide

Hans-Christian Egtvedt
2013-11-25T09:09:27Z

Around Mon 25 Nov 2013 09:55:24 +0100 or thereabout, Geert Uytterhoeven wrote:
> The extra definition for BITS_PER_LONG is also indirectly provided
> by <asm-generic/types.h>, via <asm-generic/int-ll64.h> and
> <asm/bitsperlong.h>

Are you adding a new include/asm-generic/types.h, which will include
bitsperlong.h ?

If so, nice cleaning, and you have my

> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>

Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>

> ---
> arch/avr32/include/asm/Kbuild | 1 +
> arch/avr32/include/asm/types.h | 19 -------------------
> 2 files changed, 1 insertion(+), 19 deletions(-)
> delete mode 100644 arch/avr32/include/asm/types.h
>
> diff --git a/arch/avr32/include/asm/Kbuild b/arch/avr32/include/asm/Kbuild
> index 658001b52400..129f4ff68066 100644
> --- a/arch/avr32/include/asm/Kbuild
> +++ b/arch/avr32/include/asm/Kbuild
> @@ -17,4 +17,5 @@ generic-y += scatterlist.h
> generic-y += sections.h
> generic-y += topology.h
> generic-y += trace_clock.h
> +generic-y += types.h
> generic-y += xor.h
> diff --git a/arch/avr32/include/asm/types.h b/arch/avr32/include/asm/types.h
> deleted file mode 100644
> index 59324058069c..000000000000
> --- a/arch/avr32/include/asm/types.h
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -/*
> - * Copyright (C) 2004-2006 Atmel Corporation
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License version 2 as
> - * published by the Free Software Foundation.
> - */
> -#ifndef __ASM_AVR32_TYPES_H
> -#define __ASM_AVR32_TYPES_H
> -
> -#include <uapi/asm/types.h>
> -
> -/*
> - * These aren't exported outside the kernel to avoid name space clashes
> - */
> -
> -#define BITS_PER_LONG 32
> -
> -#endif /* __ASM_AVR32_TYPES_H */
--
mvh
Hans-Christian Egtvedt