From: Joel Fernandes <joelf@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Joel Fernandes <joelf@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>
Subject: [PATCH 6/7] ARM: OMAP: Disable POSTED mode for errata i103 and i767
Date: Mon, 25 Nov 2013 15:44:35 -0600 [thread overview]
Message-ID: <1385415876-12387-7-git-send-email-joelf@ti.com> (raw)
In-Reply-To: <1385415876-12387-1-git-send-email-joelf@ti.com>
Enabling of Posted mode is seen to cause problems on dmtimer modules on AM33xx
(much like other OMAPs). Reference discussions on forums [1] [2]. Earlier
patch solving this on other OMAPs [3].
For OMAP SoCs with this errata, the fix has been to not enable Posted mode.
However, on some SoCs (atleast AM33xx) which carry this errata, Posted mode
is enabled on reset. So we not only need to ignore enabling of the POSTED bit
when the timer is requested, but also disable Posted mode if errata is present.
[1] http://e2e.ti.com/support/arm/sitara_arm/f/791/t/285744.aspx
[2] http://e2e.ti.com/support/arm/sitara_arm/f/791/t/270632.aspx
[3] http://www.spinics.net/lists/linux-omap/msg81770.html
Reported-by: Russ Dill <russ.dill@ti.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Joel Fernandes <joelf@ti.com>
---
arch/arm/plat-omap/include/plat/dmtimer.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/arm/plat-omap/include/plat/dmtimer.h b/arch/arm/plat-omap/include/plat/dmtimer.h
index fb92abb..2861b15 100644
--- a/arch/arm/plat-omap/include/plat/dmtimer.h
+++ b/arch/arm/plat-omap/include/plat/dmtimer.h
@@ -336,8 +336,11 @@ static inline void __omap_dm_timer_enable_posted(struct omap_dm_timer *timer)
if (timer->posted)
return;
- if (timer->errata & OMAP_TIMER_ERRATA_I103_I767)
+ if (timer->errata & OMAP_TIMER_ERRATA_I103_I767) {
+ timer->posted = OMAP_TIMER_NONPOSTED;
+ __omap_dm_timer_write(timer, OMAP_TIMER_IF_CTRL_REG, 0, 0);
return;
+ }
__omap_dm_timer_write(timer, OMAP_TIMER_IF_CTRL_REG,
OMAP_TIMER_CTRL_POSTED, 0);
--
1.8.1.2
next prev parent reply other threads:[~2013-11-25 21:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 21:44 [PATCH 0/7] AES/DES hwmod data and dmtimer fix Joel Fernandes
2013-11-25 21:44 ` [PATCH 1/7] ARM: OMAP: hwmod: Add SYSC offsets for AES IP Joel Fernandes
2013-11-25 21:44 ` [PATCH 2/7] ARM: DRA7xx: hwmod: Add hwmod data for DES IP Joel Fernandes
2013-11-25 21:44 ` [PATCH 3/7] ARM: DRA7xx: hwmod: Add hwmod data for AES IP Joel Fernandes
2013-11-25 21:44 ` [PATCH 4/7] ARM: OMAP4: " Joel Fernandes
2013-11-25 21:44 ` [PATCH 5/7] ARM: OMAP4: hwmod: add hwmod data for DES IP Joel Fernandes
2013-11-25 22:11 ` Tony Lindgren
2013-11-25 22:25 ` Joel Fernandes
2013-11-25 21:44 ` Joel Fernandes [this message]
2013-11-25 22:14 ` [PATCH 6/7] ARM: OMAP: Disable POSTED mode for errata i103 and i767 Tony Lindgren
2013-11-25 22:17 ` Joel Fernandes
2013-11-26 22:05 ` Tony Lindgren
2013-11-25 21:44 ` [PATCH 7/7] OMAP: AM33xx: hwmod: Correct AES module SYSC type Joel Fernandes
2013-11-25 22:12 ` [PATCH 0/7] AES/DES hwmod data and dmtimer fix Tony Lindgren
2013-11-25 22:24 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385415876-12387-7-git-send-email-joelf@ti.com \
--to=joelf@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox