From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760221Ab3K0BpV (ORCPT ); Tue, 26 Nov 2013 20:45:21 -0500 Received: from g6t0186.atlanta.hp.com ([15.193.32.63]:20907 "EHLO g6t0186.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759604Ab3K0BpP (ORCPT ); Tue, 26 Nov 2013 20:45:15 -0500 Message-ID: <1385516428.1791.198.camel@misato.fc.hp.com> Subject: Re: [PATCH 0/4] ACPI / bind: Simplify child devices lookup From: Toshi Kani To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , LKML , Linux PCI , Bjorn Helgaas , Aaron Lu Date: Tue, 26 Nov 2013 18:40:28 -0700 In-Reply-To: <6140633.otq91cJcVd@vostro.rjw.lan> References: <2610478.KxPMyuOMok@vostro.rjw.lan> <8065346.ZtkoVh8DW8@vostro.rjw.lan> <1385514717.1791.197.camel@misato.fc.hp.com> <6140633.otq91cJcVd@vostro.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5 (3.8.5-2.fc19) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2013-11-27 at 02:32 +0100, Rafael J. Wysocki wrote: > On Tuesday, November 26, 2013 06:11:57 PM Toshi Kani wrote: > > On Wed, 2013-11-27 at 02:02 +0100, Rafael J. Wysocki wrote: > > > On Tuesday, November 26, 2013 05:33:28 PM Toshi Kani wrote: > > > > On Wed, 2013-11-27 at 01:27 +0100, Rafael J. Wysocki wrote: > > > > > On Tuesday, November 26, 2013 05:00:42 PM Toshi Kani wrote: > > > > > > On Mon, 2013-11-25 at 01:09 +0100, Rafael J. Wysocki wrote: > > > > > > > Hi, > > > > > > > > > > > > > > The following series of four patches (on top of current linux-pm.git/bleeding-edge) > > > > > > > rework child device lookup in drivers/acpi/glue.c and related things: > > > > > > > > > > > > > > [1/4] ACPI / bind: Simplify child device lookup > > > > > > > [2/4] PCI/ ACPI: Use acpi_find_child_device() for child device lookup > > > > > > > [3/4] ACPI / bind: Redefine acpi_get_child() > > > > > > > [4/4] ACPI / bind: Redefine acpi_preset_companion() > > > > > > > > > > > > This patchset caused the attached panic during boot on a system. > > > > > > acpi_pci_find_device() called acpi_find_child_device() with > > > > > > ACPI_COMPANION(dev->parent) being a NULL pointer when scanning bus 0xf. > > > > > > > > > > > > This bus 0xf seems to be a chipset internal bus, which is not intended > > > > > > for the OS to use. Therefore, ACPI does not list its PCI bridge device. > > > > > > > > > > > > # lspci -tv > > > > > > : > > > > > > +-[0000:0f]-+-08.0 Intel Corporation Ivytown QPI Link 0 > > > > > > | +-08.2 Intel Corporation Ivytown QPI Link 0 > > > > > > : > > > > > > > > > > > > However, pcibios_fixup_peer_bridges(), called from pci_subsys_init(), > > > > > > finds this bus as it scans all the buses from 0 to pcibios_last_bus. > > > > > > Hence, this dev->parent does not have an associated ACPI device object. > > > > > > > > > > Thanks for the report! > > > > > > > > > > I've dropped the patches from bleeding-edge for now. > > > > > > > > > > Does "[1/4] ACPI / bind: Simplify child device lookup" alone work on that > > > > > system? > > > > > > > > Yes, the system boots fine with 1/4 alone. > > > > > > Thanks! > > > > > > Can you please check if the following modified [2/4] also works on top of it? > > > > Yes, it works fine. > > > > Thanks for the quick fix! > > No problem. :-) > > [3/4] and [4/4] on top of this one should work too. Yes, the system booted fine with 3/4 & 4/4. :-) Thanks, -Toshi