From: Ramkumar Ramachandra <artagnon@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: [PATCH v3 1/4] perf diff: color the Delta column
Date: Wed, 27 Nov 2013 16:32:31 +0530 [thread overview]
Message-ID: <1385550154-11385-2-git-send-email-artagnon@gmail.com> (raw)
In-Reply-To: <1385550154-11385-1-git-send-email-artagnon@gmail.com>
Color the numbers in the Delta column either green or red depending on
whether the number is positive or negative.
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
tools/perf/builtin-diff.c | 37 ++++++++++++++++++++++++++++++++++++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c
index 3b67ea2..fe6e200 100644
--- a/tools/perf/builtin-diff.c
+++ b/tools/perf/builtin-diff.c
@@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size)
return ret;
}
+static int hpp__color_delta(struct perf_hpp_fmt *fmt,
+ struct perf_hpp *hpp, struct hist_entry *he)
+{
+ struct diff_hpp_fmt *dfmt =
+ container_of(fmt, struct diff_hpp_fmt, fmt);
+ struct hist_entry *pair = get_pair_fmt(he, dfmt);
+ double percent;
+ char pfmt[20] = " ";
+
+ if (!pair)
+ goto dummy_print;
+ if (pair->diff.computed)
+ percent = pair->diff.period_ratio_delta;
+ else
+ percent = compute_delta(he, pair);
+
+ if (fabs(percent) >= 0.01) {
+ scnprintf(pfmt, 20, "%%%+d.2f%%%%", dfmt->header_width - 1);
+ return color_snprintf(hpp->buf, hpp->size,
+ percent > 0 ? PERF_COLOR_GREEN : PERF_COLOR_RED,
+ pfmt, percent);
+ } else
+dummy_print:
+ return scnprintf(hpp->buf, hpp->size, "%*s",
+ dfmt->header_width, pfmt);
+}
+
static void
hpp__entry_unpair(struct hist_entry *he, int idx, char *buf, size_t size)
{
@@ -940,8 +967,16 @@ static void data__hpp_register(struct data__file *d, int idx)
fmt->entry = hpp__entry_global;
/* TODO more colors */
- if (idx == PERF_HPP_DIFF__BASELINE)
+ switch (idx) {
+ case PERF_HPP_DIFF__BASELINE:
fmt->color = hpp__color_baseline;
+ break;
+ case PERF_HPP_DIFF__DELTA:
+ fmt->color = hpp__color_delta;
+ break;
+ default:
+ break;
+ }
init_header(d, dfmt);
perf_hpp__column_register(fmt);
--
1.8.5.rc0.5.g70ebc73.dirty
next prev parent reply other threads:[~2013-11-27 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 11:02 [PATCH v3 0/4] More color in 'perf diff' Ramkumar Ramachandra
2013-11-27 11:02 ` Ramkumar Ramachandra [this message]
2013-11-28 15:07 ` [PATCH v3 1/4] perf diff: color the Delta column Jiri Olsa
2013-11-28 17:24 ` Ramkumar Ramachandra
2013-11-29 13:44 ` Jiri Olsa
2013-11-27 11:02 ` [PATCH v3 2/4] perf diff: generalize hpp__color_delta for -c Ramkumar Ramachandra
2013-11-28 15:08 ` Jiri Olsa
2013-11-28 17:26 ` Ramkumar Ramachandra
2013-11-27 11:02 ` [PATCH v3 3/4] perf diff: color the Ratio column Ramkumar Ramachandra
2013-11-27 11:02 ` [PATCH v3 4/4] perf diff: color the Weighted Diff column Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385550154-11385-2-git-send-email-artagnon@gmail.com \
--to=artagnon@gmail.com \
--cc=acme@redhat.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox