From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756872Ab3K0PuD (ORCPT ); Wed, 27 Nov 2013 10:50:03 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:45288 "EHLO mail-pd0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756536Ab3K0PuA (ORCPT ); Wed, 27 Nov 2013 10:50:00 -0500 Subject: Re: [PATCH 21/22] perf tools: Add trace-event global object for tracepoint interface From: Namhyung Kim To: Jiri Olsa Cc: linux-kernel@vger.kernel.org, Corey Ashford , Frederic Weisbecker , Ingo Molnar , Paul Mackerras , Peter Zijlstra , Arnaldo Carvalho de Melo , Steven Rostedt , David Ahern In-Reply-To: <20131127152756.GF1208@krava.brq.redhat.com> References: <1385031680-9014-1-git-send-email-jolsa@redhat.com> <1385031680-9014-22-git-send-email-jolsa@redhat.com> <1385135234.1747.122.camel@leonhard> <20131125160345.GJ3161@krava.brq.redhat.com> <1385559960.1685.2.camel@leonhard> <20131127151045.GE1208@krava.brq.redhat.com> <20131127152756.GF1208@krava.brq.redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 28 Nov 2013 00:49:52 +0900 Message-ID: <1385567392.1685.54.camel@leonhard> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013-11-27 (수), 16:27 +0100, Jiri Olsa: > On Wed, Nov 27, 2013 at 04:10:45PM +0100, Jiri Olsa wrote: > > On Wed, Nov 27, 2013 at 10:46:00PM +0900, Namhyung Kim wrote: > > > Hi Jiri, > > > > > > 2013-11-25 (월), 17:03 +0100, Jiri Olsa: > > > > On Sat, Nov 23, 2013 at 12:47:14AM +0900, Namhyung Kim wrote: > > > > > 2013-11-21 (목), 12:01 +0100, Jiri Olsa: > > > > > > In order to get the proper plugins processing we need to > > > > > > use full trace-event interface when creating tracepoint > > > > > > events. So far we were using shortcut to get the parsed > > > > > > format. > > > > > > > > > > > > Moving current 'event_format__new' function into trace-event > > > > > > object as 'trace_event__tp_format'. > > > > > > > > > > > > This function uses properly initialized global trace-event > > > > > > object, ensuring proper plugins processing. > > > > > > > > > > I see this when I compile it on my old ubuntu 10.04 box (with gcc 4.4.3) > > > > > > > > > > CC util/trace-event.o > > > > > cc1: warnings being treated as errors > > > > > util/trace-event.c: In function 'trace_event__tp_format': > > > > > util/trace-event.c:63: error: not protecting function: no buffer at > > > > > least 8 bytes long > > > > > make[1]: *** [util/trace-event.o] Error 1 > > > > > > > > hum, what was the stackprotector status? > > > > > > > > ... stackprotector: [ on ] > > > > ... stackprotector-all: [ on ] > > > > > > Right. Both of them were turned on. > > > > > > Auto-detecting system features: > > > ... backtrace: [ on ] > > > ... dwarf: [ on ] > > > ... fortify-source: [ on ] > > > ... glibc: [ on ] > > > ... gtk2: [ on ] > > > ... gtk2-infobar: [ on ] > > > ... libaudit: [ on ] > > > ... libbfd: [ on ] > > > ... libelf: [ on ] > > > ... libelf-getphdrnum: [ OFF ] > > > ... libelf-mmap: [ on ] > > > ... libnuma: [ OFF ] > > > ... libperl: [ on ] > > > ... libpython: [ on ] > > > ... libpython-version: [ on ] > > > ... libslang: [ on ] > > > ... libunwind: [ OFF ] > > > ... on-exit: [ on ] > > > ... stackprotector: [ on ] > > > ... stackprotector-all: [ on ] > > > ... timerfd: [ on ] > > > > I found that -fstack-protector might not always work: > > https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/691722 > > > > they say it was fixed in gcc 4.5.0 which I was not > > able to prove in gcc release notes.. > > > > we could disable the warning like in the below > > for gcc < 4.5.0, could you please test? Works well for me, thanks. > > > > any other idea? ;-) > > or remove -Wstack-protector option completely, as it's just informative > seems there's nothing you could do about the warning anyway Agreed. It seems just adding -fstack-protector is enough. Thanks, Namhyung