* [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator
@ 2013-11-30 4:21 Axel Lin
2013-12-02 10:59 ` Lee Jones
2013-12-02 17:59 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2013-11-30 4:21 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones, Mark Brown
Cc: Balaji Rao, Liam Girdwood, linux-kernel
Change the device name of the regulator function to the one chosen for
MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have the hardware to test, but I think this needs fix.
We have a similar fix in
commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".
drivers/mfd/pcf50633-core.c | 2 +-
drivers/regulator/pcf50633-regulator.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 6841d68..41ab5e3 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
struct platform_device *pdev;
- pdev = platform_device_alloc("pcf50633-regltr", i);
+ pdev = platform_device_alloc("pcf50633-regulator", i);
if (!pdev) {
dev_err(pcf->dev, "Cannot create regulator %d\n", i);
continue;
diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
index d7da1c1..134f90e 100644
--- a/drivers/regulator/pcf50633-regulator.c
+++ b/drivers/regulator/pcf50633-regulator.c
@@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)
static struct platform_driver pcf50633_regulator_driver = {
.driver = {
- .name = "pcf50633-regltr",
+ .name = "pcf50633-regulator",
},
.probe = pcf50633_regulator_probe,
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator
2013-11-30 4:21 [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator Axel Lin
@ 2013-12-02 10:59 ` Lee Jones
2013-12-02 17:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-12-02 10:59 UTC (permalink / raw)
To: Axel Lin
Cc: Samuel Ortiz, Mark Brown, Balaji Rao, Liam Girdwood, linux-kernel
On Sat, 30 Nov 2013, Axel Lin wrote:
> Change the device name of the regulator function to the one chosen for
> MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have the hardware to test, but I think this needs fix.
> We have a similar fix in
> commit ec8da805c43a "mfd: tps6586x: correct device name of the regulator cell".
>
> drivers/mfd/pcf50633-core.c | 2 +-
> drivers/regulator/pcf50633-regulator.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Patch looks fine to me and I can't fine any other instances of the
name.
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index 6841d68..41ab5e3 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -245,7 +245,7 @@ static int pcf50633_probe(struct i2c_client *client,
> for (i = 0; i < PCF50633_NUM_REGULATORS; i++) {
> struct platform_device *pdev;
>
> - pdev = platform_device_alloc("pcf50633-regltr", i);
> + pdev = platform_device_alloc("pcf50633-regulator", i);
> if (!pdev) {
> dev_err(pcf->dev, "Cannot create regulator %d\n", i);
> continue;
> diff --git a/drivers/regulator/pcf50633-regulator.c b/drivers/regulator/pcf50633-regulator.c
> index d7da1c1..134f90e 100644
> --- a/drivers/regulator/pcf50633-regulator.c
> +++ b/drivers/regulator/pcf50633-regulator.c
> @@ -105,7 +105,7 @@ static int pcf50633_regulator_probe(struct platform_device *pdev)
>
> static struct platform_driver pcf50633_regulator_driver = {
> .driver = {
> - .name = "pcf50633-regltr",
> + .name = "pcf50633-regulator",
> },
> .probe = pcf50633_regulator_probe,
> };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator
2013-11-30 4:21 [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator Axel Lin
2013-12-02 10:59 ` Lee Jones
@ 2013-12-02 17:59 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-12-02 17:59 UTC (permalink / raw)
To: Axel Lin; +Cc: Samuel Ortiz, Lee Jones, Balaji Rao, Liam Girdwood, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
On Sat, Nov 30, 2013 at 12:21:03PM +0800, Axel Lin wrote:
> Change the device name of the regulator function to the one chosen for
> MODULE_ALIAS. This fixes kernel auto-module loading for the regulator function.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-02 17:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-30 4:21 [RFT][PATCH] mfd: pcf50633: Correct device name for pcf50633 regulator Axel Lin
2013-12-02 10:59 ` Lee Jones
2013-12-02 17:59 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox