Re: [PATCH] drivers: staging: media: go7007: go7007-usb.c use pr_*() instead of dev_*() before 'go' initialized in go7007_usb_probe()

Chen Gang
2013-11-27T03:38:15Z

On 11/27/2013 11:21 AM, Joe Perches wrote:
> On Wed, 2013-11-27 at 11:17 +0800, Chen Gang wrote:
>> dev_*() assumes 'go' is already initialized, so need use pr_*() instead
>> of before 'go' initialized.
> []
>> diff --git a/drivers/staging/media/go7007/go7007-usb.c b/drivers/staging/media/go7007/go7007-usb.c
> []
>> @@ -1057,7 +1057,7 @@ static int go7007_usb_probe(struct usb_interface *intf,
>> char *name;
>> int video_pipe, i, v_urb_len;
>>
>> - dev_dbg(go->dev, "probing new GO7007 USB board\n");
>> + pr_devel("probing new GO7007 USB board\n");
>
> pr_devel is commonly compiled out completely unless DEBUG is #defined.
> You probably want to use pr_debug here.
>
>

Oh, yes, it is my fault, I will send patch v2. :-)

Thanks.
--
Chen Gang