Re: [PATCH] drivers: scsi: scsi_lib.c: add prefix "SCSILIB_" to macro "SP"

rkuo
2013-12-02T21:32:52Z

On Mon, Dec 02, 2013 at 06:14:33PM +0800, Chen Gang wrote:
> If one issue occurs, normally, both sides need improvement.
>
> For our issue:
>
> - need try to keep uapi no touch ("arch/hexagon/uapi/asm/registers.h").
>
> - improving our module is much easier than improving hexagon.
>
> - for 'SP', it is really short enough to like a register name.
> SG_POOL seems more suitable for our 'sgpool' related operations.
>
>
> It will be better to improve hexagon too, but it is not quit easy (maybe
> have to bear it), it is uapi :-(

I can't speak for SCSI, but that define in Hexagon isn't really used outside
of that file anyways (the two SP macros themselves). I'm also pretty sure
the userspace isn't currently using it anyways. Seeing as it's not really
buying us anything, I'm fine with just removing it and continuing to review
the other defines. I'll make that change and test it locally.

Thanks,
Richard Kuo

--

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation