Re: [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case

Chen Gang
2013-12-04T02:10:34Z

On 12/02/2013 10:48 PM, Johannes Berg wrote:
> On Sun, 2013-12-01 at 14:38 -0800, Joe Perches wrote:
>> On Sun, 2013-12-01 at 10:35 +0100, Johannes Berg wrote:
>>> Good try, but no, now ap_sdata isn't even assigned. :)
>>
>> Right. Oh well. There's no improving this without
>> significant rewrite. Even then, there may not be much
>> overall improvement.
>
> I could see an improvement if we were to actually make changes to assign
> the pointer based on the iftype, when that changes, so that each
> function only has to handle the right type and we don't need the switch
> statement at all...
>

OK, thanks, it is one of good ideas to me (which I can not find). :-)

> But that's tricky to get right and I'm between vacations and holidays
> and all that ...
>

It is really not urgent, and for keeping quality, it is necessary to
spend suitable time resource (e.g 1 hour or more) to make, review and
test this kind of patch carefully by oneself.

So could you please help improve it when you have suitable related time
resources?

Thanks.
--
Chen Gang