From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932207Ab3LBUtb (ORCPT ); Mon, 2 Dec 2013 15:49:31 -0500 Received: from merlin.infradead.org ([205.233.59.134]:54065 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757305Ab3LBUtU (ORCPT ); Mon, 2 Dec 2013 15:49:20 -0500 From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Adrian Hunter , David Ahern , Frederic Weisbecker , Mike Galbraith , Namhyung Kim , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 03/12] perf tools: Fine tune readn function Date: Mon, 2 Dec 2013 17:49:00 -0300 Message-Id: <1386017349-24486-4-git-send-email-acme@infradead.org> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1386017349-24486-1-git-send-email-acme@infradead.org> References: <1386017349-24486-1-git-send-email-acme@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by merlin.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa Added a 'left' variable to make the flow clearer, and added a debug check for the return value - returning 'n' is more obvious. Added small comment for readn. Signed-off-by: Jiri Olsa Original-patch-by: Ingo Molnar Cc: Adrian Hunter Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Mike Galbraith Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1385634619-8129-4-git-send-email-jolsa@redhat.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/util.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c index 9440481e9092..6ea0b4ae9569 100644 --- a/tools/perf/util/util.c +++ b/tools/perf/util/util.c @@ -6,6 +6,7 @@ #endif #include #include +#include /* * XXX We need to find a better place for these things... @@ -151,21 +152,26 @@ unsigned long convert_unit(unsigned long value, char *unit) return value; } +/* + * Read exactly 'n' bytes or return an error. + */ ssize_t readn(int fd, void *buf, size_t n) { void *buf_start = buf; + size_t left = n; - while (n) { - ssize_t ret = read(fd, buf, n); + while (left) { + ssize_t ret = read(fd, buf, left); if (ret <= 0) return ret; - n -= ret; - buf += ret; + left -= ret; + buf += ret; } - return buf - buf_start; + BUG_ON((size_t)(buf - buf_start) != n); + return n; } size_t hex_width(u64 v) -- 1.8.1.4