From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Adrian Hunter <adrian.hunter@intel.com>,
David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 04/12] perf tools: Add writen function
Date: Mon, 2 Dec 2013 17:49:01 -0300 [thread overview]
Message-ID: <1386017349-24486-5-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1386017349-24486-1-git-send-email-acme@infradead.org>
From: Jiri Olsa <jolsa@redhat.com>
Adding 'writen' function as a synchronous wrapper for write syscall with
following prototype:
ssize_t writen(int fd, void *buf, size_t n)
Returns the number of bytes written on success or -1 in case of err.
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
Requested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1385634619-8129-5-git-send-email-jolsa@redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/util.c | 24 +++++++++++++++++++-----
tools/perf/util/util.h | 1 +
2 files changed, 20 insertions(+), 5 deletions(-)
diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
index 6ea0b4ae9569..b1d5376b9dd9 100644
--- a/tools/perf/util/util.c
+++ b/tools/perf/util/util.c
@@ -152,16 +152,14 @@ unsigned long convert_unit(unsigned long value, char *unit)
return value;
}
-/*
- * Read exactly 'n' bytes or return an error.
- */
-ssize_t readn(int fd, void *buf, size_t n)
+static ssize_t ion(bool is_read, int fd, void *buf, size_t n)
{
void *buf_start = buf;
size_t left = n;
while (left) {
- ssize_t ret = read(fd, buf, left);
+ ssize_t ret = is_read ? read(fd, buf, left) :
+ write(fd, buf, left);
if (ret <= 0)
return ret;
@@ -174,6 +172,22 @@ ssize_t readn(int fd, void *buf, size_t n)
return n;
}
+/*
+ * Read exactly 'n' bytes or return an error.
+ */
+ssize_t readn(int fd, void *buf, size_t n)
+{
+ return ion(true, fd, buf, n);
+}
+
+/*
+ * Write exactly 'n' bytes or return an error.
+ */
+ssize_t writen(int fd, void *buf, size_t n)
+{
+ return ion(false, fd, buf, n);
+}
+
size_t hex_width(u64 v)
{
size_t n = 1;
diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
index 9f6b928f6b2b..ce0f73d4d91f 100644
--- a/tools/perf/util/util.h
+++ b/tools/perf/util/util.h
@@ -254,6 +254,7 @@ int strtailcmp(const char *s1, const char *s2);
char *strxfrchar(char *s, char from, char to);
unsigned long convert_unit(unsigned long value, char *unit);
ssize_t readn(int fd, void *buf, size_t n);
+ssize_t writen(int fd, void *buf, size_t n);
struct perf_event_attr;
--
1.8.1.4
next prev parent reply other threads:[~2013-12-02 20:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 20:48 [GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-12-02 20:48 ` [PATCH 01/12] perf record: Unify data output code into perf_record__write function Arnaldo Carvalho de Melo
2013-12-02 20:48 ` [PATCH 02/12] perf tools: Use correct return type for readn function Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 03/12] perf tools: Fine tune " Arnaldo Carvalho de Melo
2013-12-02 20:49 ` Arnaldo Carvalho de Melo [this message]
2013-12-02 20:49 ` [PATCH 05/12] perf tools: Add perf_data_file__write interface Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 06/12] perf timechart: Introduce tool struct Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 07/12] perf timechart: Move all_data per_pid list to 'struct timechart' Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 08/12] perf timechart: Move power_events " Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 09/12] perf timechart: Move wake_events " Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 10/12] perf tools: Correct the message in feature-libnuma checking Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 11/12] perf tools: Include test-stackprotector-all.c in test-all Arnaldo Carvalho de Melo
2013-12-02 20:49 ` [PATCH 12/12] perf trace: Honour -m option Arnaldo Carvalho de Melo
2013-12-04 9:18 ` [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386017349-24486-5-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).