From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, "'Koul,
Vinod'" <vinod.koul@intel.com>,
"'Williams, Dan J'" <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, "'Joe Perches'" <joe@perches.com>,
"'Jonas Bonn'" <jonas@southpole.se>
Subject: Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro
Date: Wed, 04 Dec 2013 14:48:30 +0200 [thread overview]
Message-ID: <1386161310.1871.62.camel@smile> (raw)
In-Reply-To: <001501cef086$78d015f0$6a7041d0$%han@samsung.com>
On Wed, 2013-12-04 at 09:19 +0900, Jingoo Han wrote:
> On Tuesday, December 03, 2013 9:11 PM, Shevchenko, Andriy wrote:
> > On Tue, 2013-12-03 at 08:05 +0900, Jingoo Han wrote:
> > > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > > is not preferred.
> >
> > I'm sorry, but Documentation/PCI/pci.txt still says "is the preferred
> > method".
> >
> > Is there any link to patch for Documentation and discussion why change
> > is established?
>
> (+cc Joe Perches, Jonas Bonn)
>
> Since last week, there has been discussion about this.
> There is no special reason to use DEFINE_PCI_DEVICE_TABLE macro.
>
> According to the Greg Kroah-Hartman,
> "Yeah, and it's a horrid macro that deserves to be removed,
> please don't use it in more places."
>
> Currently, there is no other bus that has something like this
> macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro
> should be removed.
>
> Jonas Bonn (author of DEFINE_PCI_DEVICE_TABLE macro) also agreed
> to remove this macro. According to Jonas Bonn,
> "Actually, I think I submitted an even uglier macro called
> DECLARE_PCI_DEVICE_TABLE... might have been the first kernel
> Patch I ever sent? In any case, it should certainly have been
> kindly rejected."
>
> After Joe Perches's patch[1] is merged, I will send these patches
> to each subsystem maintainer.
>
> [1][PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE
> (http://lkml.org/lkml/2013/12/2/400)
>
> In this patch, Joe Perches fixed 'Documentation/PCI/pci.txt', and
> 'scripts/checkpatch.pl', in order to guide to use 'struct pci_device_id'
> instead of 'DEFINE_PCI_DEVICE_TABLE' macro.
Thanks for the detailed explanation!
Thus, give you my
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for drivers/dma/dw/ part.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2013-12-04 12:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001501ceefb1$69c96820$3d5c3860$%han@samsung.com>
2013-12-02 22:58 ` [PATCH 01/39] perf/x86/intel: remove DEFINE_PCI_DEVICE_TABLE macro Jingoo Han
2013-12-02 23:00 ` [PATCH 02/39] bcma: pci: " Jingoo Han
2013-12-02 23:01 ` [PATCH 03/39] block: " Jingoo Han
2013-12-02 23:03 ` [PATCH 04/39] char: amd64-agp: " Jingoo Han
2013-12-02 23:04 ` [PATCH 05/39] cpufreq: nforce2: " Jingoo Han
2013-12-03 5:54 ` Viresh Kumar
2013-12-02 23:05 ` [PATCH 06/39] dma: " Jingoo Han
2013-12-02 23:11 ` Joe Perches
2013-12-03 12:11 ` Shevchenko, Andriy
2013-12-04 0:19 ` Jingoo Han
2013-12-04 12:48 ` Andy Shevchenko [this message]
2013-12-02 23:07 ` [PATCH 07/39] edac: " Jingoo Han
2013-12-02 23:20 ` Borislav Petkov
2013-12-02 23:35 ` Jingoo Han
2013-12-06 9:25 ` Borislav Petkov
2013-12-02 23:08 ` [PATCH 08/39] gpio: " Jingoo Han
2013-12-03 12:16 ` Linus Walleij
2013-12-02 23:09 ` [PATCH 09/39] drm: " Jingoo Han
2013-12-02 23:10 ` [PATCH 10/39] hwmon: " Jingoo Han
2013-12-03 0:17 ` Guenter Roeck
2013-12-03 8:02 ` Jean Delvare
2013-12-03 14:32 ` Guenter Roeck
2013-12-03 2:42 ` Guenter Roeck
2013-12-02 23:11 ` [PATCH 11/39] i2c: " Jingoo Han
2013-12-02 23:12 ` [PATCH 12/39] IB: " Jingoo Han
2013-12-02 23:13 ` [PATCH 13/39] ipack: " Jingoo Han
2013-12-02 23:13 ` [PATCH 14/39] leds: leds-ss4200: " Jingoo Han
2013-12-02 23:15 ` [PATCH 15/39] media: pci: " Jingoo Han
2013-12-02 23:15 ` [PATCH 16/39] mfd: " Jingoo Han
2013-12-03 8:11 ` Lee Jones
2013-12-02 23:16 ` [PATCH 17/39] misc: " Jingoo Han
2013-12-02 23:17 ` [PATCH 18/39] mmc: dw_mmc-pci: " Jingoo Han
2013-12-02 23:18 ` [PATCH 19/39] mtd: denali: " Jingoo Han
2013-12-10 7:13 ` Brian Norris
2013-12-02 23:19 ` [PATCH 20/39] net: " Jingoo Han
2013-12-03 2:36 ` Stephen Hemminger
2013-12-03 2:44 ` Jingoo Han
2013-12-02 23:20 ` [PATCH 21/39] NTB: " Jingoo Han
2013-12-02 23:20 ` [PATCH 22/39] pcmcia: " Jingoo Han
2013-12-02 23:21 ` PATCH 23/39] platform: x86: " Jingoo Han
2013-12-02 23:23 ` [PATCH 24/39] ptp: ptp_pch: " Jingoo Han
2013-12-02 23:24 ` [PATCH 25/39] rapidio: tsi721: " Jingoo Han
2013-12-02 23:24 ` [PATCH 26/39] scsi: " Jingoo Han
2013-12-02 23:25 ` [PATCH 27/39] spi: " Jingoo Han
2013-12-03 18:04 ` Mark Brown
2013-12-02 23:26 ` [PATCH 28/39] staging: " Jingoo Han
2013-12-05 9:06 ` ZHAO Gang
2013-12-05 15:43 ` Greg Kroah-Hartman
2013-12-06 0:50 ` ZHAO Gang
2013-12-02 23:26 ` [PATCH 29/39] tty: " Jingoo Han
2013-12-02 23:27 ` [PATCH 30/39] uio: uio_mf624: " Jingoo Han
2013-12-02 23:27 ` [PATCH 31/39] USB: " Jingoo Han
2013-12-09 4:03 ` Felipe Balbi
2013-12-09 8:33 ` 'Greg Kroah-Hartman'
2013-12-10 2:56 ` Felipe Balbi
2013-12-02 23:28 ` [PATCH 32/39] video: " Jingoo Han
2013-12-02 23:29 ` [PATCH 33/39] virtio: pci: " Jingoo Han
2013-12-02 23:29 ` [PATCH 34/39] vme: " Jingoo Han
2013-12-05 9:14 ` ZHAO Gang
2013-12-05 15:43 ` Greg Kroah-Hartman
2013-12-02 23:30 ` [PATCH 35/39] watchdog: " Jingoo Han
2013-12-03 4:09 ` Guenter Roeck
2013-12-02 23:30 ` [PATCH 36/39] xen: pciback: " Jingoo Han
2013-12-02 23:31 ` [PATCH 37/39] sound: " Jingoo Han
2013-12-02 23:32 ` [PATCH 38/39] PCI: " Jingoo Han
2013-12-02 23:52 ` Joe Perches
2013-12-03 1:15 ` Jingoo Han
2013-12-03 1:27 ` 'Greg Kroah-Hartman'
2013-12-02 23:32 ` [PATCH 39/39] checkpatch: remove check for " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386161310.1871.62.camel@smile \
--to=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox