public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "ethan.zhao" <ethan.kernel@gmail.com>
To: gregkh@linuxfoundation.org, konrad.wilk@oracle.com,
	raghavendra.kt@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, "ethan.zhao" <ethan.kernel@gmail.com>
Subject: [PATCH] xen/debugfs: Check debugfs initialization before using it
Date: Sun,  8 Dec 2013 19:31:02 +0800	[thread overview]
Message-ID: <1386502262-1163-1-git-send-email-ethan.kernel@gmail.com> (raw)

Should check debugfs initialization with debugfs_initialized() before using it,
Because if it isn't initialized, the return value of fake debugfs_create_dir() etc
functions would be ERR_PTR(-ENODEV), checking with NULL will not work.

Signed-off-by: ethan.zhao <ethan.kernel@gmail.com>
---
 arch/x86/xen/debugfs.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/x86/xen/debugfs.c b/arch/x86/xen/debugfs.c
index c8377fb..85c0e0e 100644
--- a/arch/x86/xen/debugfs.c
+++ b/arch/x86/xen/debugfs.c
@@ -9,12 +9,18 @@ static struct dentry *d_xen_debug;
 
 struct dentry * __init xen_init_debugfs(void)
 {
+	if (!debugfs_initialized()) {
+		d_xen_debug = NULL;
+		goto nodebugfs;
+	}
+
 	if (!d_xen_debug) {
 		d_xen_debug = debugfs_create_dir("xen", NULL);
 
 		if (!d_xen_debug)
 			pr_warning("Could not create 'xen' debugfs directory\n");
 	}
+nodebugfs:
 
 	return d_xen_debug;
 }
-- 
1.8.3.4 (Apple Git-47)


             reply	other threads:[~2013-12-08 11:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08 11:31 ethan.zhao [this message]
2013-12-08 14:01 ` [PATCH] xen/debugfs: Check debugfs initialization before using it Greg KH
2013-12-09  1:43   ` Ethan Zhao
2013-12-09  8:25     ` Greg KH
2013-12-09  8:44       ` Ethan Zhao
2013-12-09  8:55         ` Greg KH
2013-12-09  9:57           ` Ethan Zhao
2013-12-09 11:17             ` Greg KH
2013-12-09 13:42               ` Ethan Zhao
2013-12-09 18:40                 ` Greg KH
2013-12-10  8:03                   ` Ethan Zhao
2013-12-10  8:19                     ` Greg KH
2013-12-11  2:31                       ` Ethan Zhao
  -- strict thread matches above, loose matches on Subject: below --
2013-12-09 10:04 Ethan Zhao
2013-12-09 11:18 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386502262-1163-1-git-send-email-ethan.kernel@gmail.com \
    --to=ethan.kernel@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox