public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alex Davis <alex14641@yahoo.com>
To: "mjg59@srcf.ucam.org" <mjg59@srcf.ucam.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] dell-laptop: add parameter to disable the backlight device.
Date: Sun, 8 Dec 2013 05:40:31 -0800 (PST)	[thread overview]
Message-ID: <1386510031.81267.YahooMailNeo@web160401.mail.bf1.yahoo.com> (raw)

I have a Dell Inspiron N7010 Laptop with Intel graphics. When the dell-laptop module is loaded,
two backlight device devices are created; dell_backlight, and intel_backlight from the Intel
graphics driver. The dell_backlight device is non-functional, but the graphics subsystem uses
it instead of the functioning intel_backlight device. The result is that, when running KDE,
screen brightness cannot be controlled. I've added a module parameter, disable_backlight
which, when true, will disable the dell_backlight device, and leave only the intel_backlight:
with this, screen brightness can be controlled.

This patch is against 3.10.

Signed-off-by: Alex Davis <alex14641@yahoo.com>
--- dell-laptop.c.orig    2013-12-01 19:05:39.693149050 -0500
+++ dell-laptop.c    2013-12-01 17:29:27.613372482 -0500
@@ -35,6 +35,9 @@
 /* This structure will be modified by the firmware when we enter
  * system management mode, hence the volatiles */
 
+static bool disable_backlight;
+module_param(disable_backlight, bool, 0644);
+
 struct calling_interface_buffer {
     u16 class;
     u16 select;
@@ -561,6 +564,9 @@ static int __init dell_init(void)
 
     dell_laptop_dir = debugfs_create_dir("dell_laptop", NULL);
 
+    if (disable_backlight)
+        return 0;
+
 #ifdef CONFIG_ACPI
     /* In the event of an ACPI backlight being available, don't
      * register the platform controller.

 
I code, therefore I am

             reply	other threads:[~2013-12-08 13:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-08 13:40 Alex Davis [this message]
2013-12-08 14:06 ` [PATCH] dell-laptop: add parameter to disable the backlight device Levente Kurusa
2013-12-08 20:38   ` Alex Davis
2013-12-08 23:43     ` Alex Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386510031.81267.YahooMailNeo@web160401.mail.bf1.yahoo.com \
    --to=alex14641@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox