* Re: [PATCH] SFI: fix compilation warnings [not found] <1386264397-27319-1-git-send-email-andriy.shevchenko@linux.intel.com> @ 2013-12-05 22:36 ` Rafael J. Wysocki 2013-12-05 22:40 ` Rafael J. Wysocki 2013-12-06 1:08 ` Zheng, Lv 0 siblings, 2 replies; 8+ messages in thread From: Rafael J. Wysocki @ 2013-12-05 22:36 UTC (permalink / raw) To: Andy Shevchenko, Lv Zheng; +Cc: Rafael J . Wysocki, linux-acpi, LKML On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > When build kernel with make W=1 we get the following compiler error. > > In file included from drivers/sfi/sfi_acpi.c:66:0: > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > if (!acpi_table_parse(signature, handler)) > ^ > cc1: some warnings being treated as errors > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> OK Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing out entirely for the next cycle. Thanks! > --- > drivers/sfi/sfi_acpi.c | 2 +- > include/linux/sfi_acpi.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/sfi/sfi_acpi.c b/drivers/sfi/sfi_acpi.c > index 0c9f419..d4dfcbe 100644 > --- a/drivers/sfi/sfi_acpi.c > +++ b/drivers/sfi/sfi_acpi.c > @@ -60,7 +60,7 @@ > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > #include <linux/kernel.h> > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > +#include <linux/acpi.h> > > #include <linux/sfi.h> > #include <linux/sfi_acpi.h> > diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h > index 2cfcb79..c9cab82 100644 > --- a/include/linux/sfi_acpi.h > +++ b/include/linux/sfi_acpi.h > @@ -60,7 +60,7 @@ > #define _LINUX_SFI_ACPI_H > > #ifdef CONFIG_SFI > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > +#include <linux/acpi.h> > > extern int sfi_acpi_table_parse(char *signature, char *oem_id, > char *oem_table_id, > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] SFI: fix compilation warnings 2013-12-05 22:36 ` [PATCH] SFI: fix compilation warnings Rafael J. Wysocki @ 2013-12-05 22:40 ` Rafael J. Wysocki 2013-12-06 1:08 ` Zheng, Lv 1 sibling, 0 replies; 8+ messages in thread From: Rafael J. Wysocki @ 2013-12-05 22:40 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Lv Zheng, Rafael J . Wysocki, linux-acpi, LKML On Thursday, December 05, 2013 11:36:37 PM Rafael J. Wysocki wrote: > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > When build kernel with make W=1 we get the following compiler error. > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > > if (!acpi_table_parse(signature, handler)) > > ^ > > cc1: some warnings being treated as errors > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > OK > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > out entirely for the next cycle. Or rather I'll keep it in bleeding-edge and wait for follow-up patches to fix build problems like this one (then we can merge it into 3.14 hopefully). Thanks! > > --- > > drivers/sfi/sfi_acpi.c | 2 +- > > include/linux/sfi_acpi.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/sfi/sfi_acpi.c b/drivers/sfi/sfi_acpi.c > > index 0c9f419..d4dfcbe 100644 > > --- a/drivers/sfi/sfi_acpi.c > > +++ b/drivers/sfi/sfi_acpi.c > > @@ -60,7 +60,7 @@ > > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > > > #include <linux/kernel.h> > > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > > +#include <linux/acpi.h> > > > > #include <linux/sfi.h> > > #include <linux/sfi_acpi.h> > > diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h > > index 2cfcb79..c9cab82 100644 > > --- a/include/linux/sfi_acpi.h > > +++ b/include/linux/sfi_acpi.h > > @@ -60,7 +60,7 @@ > > #define _LINUX_SFI_ACPI_H > > > > #ifdef CONFIG_SFI > > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > > +#include <linux/acpi.h> > > > > extern int sfi_acpi_table_parse(char *signature, char *oem_id, > > char *oem_table_id, > > > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] SFI: fix compilation warnings 2013-12-05 22:36 ` [PATCH] SFI: fix compilation warnings Rafael J. Wysocki 2013-12-05 22:40 ` Rafael J. Wysocki @ 2013-12-06 1:08 ` Zheng, Lv 2013-12-06 1:25 ` Rafael J. Wysocki 1 sibling, 1 reply; 8+ messages in thread From: Zheng, Lv @ 2013-12-06 1:08 UTC (permalink / raw) To: Rafael J. Wysocki, Andy Shevchenko Cc: Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2427 bytes --] > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Friday, December 06, 2013 6:37 AM > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > When build kernel with make W=1 we get the following compiler error. > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > include/linux/sfi_acpi.h: In function âacpi_sfi_table_parseâ: > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function âacpi_table_parseâ [-Werror=implicit-function-declaration] > > if (!acpi_table_parse(signature, handler)) > > ^ > > cc1: some warnings being treated as errors > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > OK > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > out entirely for the next cycle. No, I think Andy's patch is wrong. This warning is existing before merging my fixes. Either we fix this warning or leave it as is. To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. Let me post a fix for this. Thanks -Lv > > Thanks! > > > --- > > drivers/sfi/sfi_acpi.c | 2 +- > > include/linux/sfi_acpi.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/sfi/sfi_acpi.c b/drivers/sfi/sfi_acpi.c > > index 0c9f419..d4dfcbe 100644 > > --- a/drivers/sfi/sfi_acpi.c > > +++ b/drivers/sfi/sfi_acpi.c > > @@ -60,7 +60,7 @@ > > #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt > > > > #include <linux/kernel.h> > > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > > +#include <linux/acpi.h> > > > > #include <linux/sfi.h> > > #include <linux/sfi_acpi.h> > > diff --git a/include/linux/sfi_acpi.h b/include/linux/sfi_acpi.h > > index 2cfcb79..c9cab82 100644 > > --- a/include/linux/sfi_acpi.h > > +++ b/include/linux/sfi_acpi.h > > @@ -60,7 +60,7 @@ > > #define _LINUX_SFI_ACPI_H > > > > #ifdef CONFIG_SFI > > -#include <acpi/acpi.h> /* FIXME: inclusion should be removed */ > > +#include <linux/acpi.h> > > > > extern int sfi_acpi_table_parse(char *signature, char *oem_id, > > char *oem_table_id, > > > -- > I speak only for myself. > Rafael J. Wysocki, Intel Open Source Technology Center. ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] SFI: fix compilation warnings 2013-12-06 1:08 ` Zheng, Lv @ 2013-12-06 1:25 ` Rafael J. Wysocki 2013-12-06 1:26 ` Zheng, Lv 0 siblings, 1 reply; 8+ messages in thread From: Rafael J. Wysocki @ 2013-12-06 1:25 UTC (permalink / raw) To: Zheng, Lv Cc: Andy Shevchenko, Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > Sent: Friday, December 06, 2013 6:37 AM > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > When build kernel with make W=1 we get the following compiler error. > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > > > if (!acpi_table_parse(signature, handler)) > > > ^ > > > cc1: some warnings being treated as errors > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > OK > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > > out entirely for the next cycle. > > No, I think Andy's patch is wrong. His patch may be wrong, but the warning in his changelog surely is real. :-) > This warning is existing before merging my fixes. > > Either we fix this warning or leave it as is. > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. > Let me post a fix for this. Please do. And I'm putting all ACPI header cleanups on hold until all warnings of this kind have been fixed by them. Otherwise doing those cleanups makes a little sense in my opinion. Thanks, Rafael ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] SFI: fix compilation warnings 2013-12-06 1:25 ` Rafael J. Wysocki @ 2013-12-06 1:26 ` Zheng, Lv 2013-12-06 2:00 ` Rafael J. Wysocki 0 siblings, 1 reply; 8+ messages in thread From: Zheng, Lv @ 2013-12-06 1:26 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Andy Shevchenko, Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2078 bytes --] > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > Sent: Friday, December 06, 2013 9:26 AM > > On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > Sent: Friday, December 06, 2013 6:37 AM > > > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > > When build kernel with make W=1 we get the following compiler error. > > > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > > include/linux/sfi_acpi.h: In function âacpi_sfi_table_parseâ: > > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function âacpi_table_parseâ [-Werror=implicit-function-declaration] > > > > if (!acpi_table_parse(signature, handler)) > > > > ^ > > > > cc1: some warnings being treated as errors > > > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > OK > > > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > > > out entirely for the next cycle. > > > > No, I think Andy's patch is wrong. > > His patch may be wrong, but the warning in his changelog surely is real. :-) > > > This warning is existing before merging my fixes. > > > > Either we fix this warning or leave it as is. > > > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. > > Let me post a fix for this. > > Please do. And I'm putting all ACPI header cleanups on hold until all warnings > of this kind have been fixed by them. Otherwise doing those cleanups makes a > little sense in my opinion. OK, not only this warning, there is another warning in sfi_acpi.c. I doubt whether they are strictly tested before upstreamed... They are all existing warnings. You can apply my new patch before the cleanup series. Thanks -Lv > > Thanks, > Rafael ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] SFI: fix compilation warnings 2013-12-06 1:26 ` Zheng, Lv @ 2013-12-06 2:00 ` Rafael J. Wysocki 2013-12-06 1:51 ` Zheng, Lv 0 siblings, 1 reply; 8+ messages in thread From: Rafael J. Wysocki @ 2013-12-06 2:00 UTC (permalink / raw) To: Zheng, Lv Cc: Andy Shevchenko, Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML On Friday, December 06, 2013 01:26:07 AM Zheng, Lv wrote: > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > Sent: Friday, December 06, 2013 9:26 AM > > > > On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > Sent: Friday, December 06, 2013 6:37 AM > > > > > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > > > When build kernel with make W=1 we get the following compiler error. > > > > > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > > > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > > > > > if (!acpi_table_parse(signature, handler)) > > > > > ^ > > > > > cc1: some warnings being treated as errors > > > > > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > OK > > > > > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > > > > out entirely for the next cycle. > > > > > > No, I think Andy's patch is wrong. > > > > His patch may be wrong, but the warning in his changelog surely is real. :-) > > > > > This warning is existing before merging my fixes. > > > > > > Either we fix this warning or leave it as is. > > > > > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. > > > Let me post a fix for this. > > > > Please do. And I'm putting all ACPI header cleanups on hold until all warnings > > of this kind have been fixed by them. Otherwise doing those cleanups makes a > > little sense in my opinion. > > OK, not only this warning, there is another warning in sfi_acpi.c. > I doubt whether they are strictly tested before upstreamed... > They are all existing warnings. > You can apply my new patch before the cleanup series. Sorry, I'm already lost in the thick of patches. :-) Please resend them all as a single series. Thanks, Rafael ^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: [PATCH] SFI: fix compilation warnings 2013-12-06 2:00 ` Rafael J. Wysocki @ 2013-12-06 1:51 ` Zheng, Lv 2013-12-09 8:56 ` Andy Shevchenko 0 siblings, 1 reply; 8+ messages in thread From: Zheng, Lv @ 2013-12-06 1:51 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Andy Shevchenko, Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2954 bytes --] > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Friday, December 06, 2013 10:01 AM > To: Zheng, Lv > Cc: Andy Shevchenko; Wysocki, Rafael J; linux-acpi@vger.kernel.org; LKML > Subject: Re: [PATCH] SFI: fix compilation warnings > > On Friday, December 06, 2013 01:26:07 AM Zheng, Lv wrote: > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > Sent: Friday, December 06, 2013 9:26 AM > > > > > > On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > > Sent: Friday, December 06, 2013 6:37 AM > > > > > > > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > > > > When build kernel with make W=1 we get the following compiler error. > > > > > > > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > > > > include/linux/sfi_acpi.h: In function âacpi_sfi_table_parseâ: > > > > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function âacpi_table_parseâ [-Werror=implicit-function-declaration] > > > > > > if (!acpi_table_parse(signature, handler)) > > > > > > ^ > > > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > > > OK > > > > > > > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > > > > > out entirely for the next cycle. > > > > > > > > No, I think Andy's patch is wrong. > > > > > > His patch may be wrong, but the warning in his changelog surely is real. :-) > > > > > > > This warning is existing before merging my fixes. > > > > > > > > Either we fix this warning or leave it as is. > > > > > > > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. > > > > Let me post a fix for this. > > > > > > Please do. And I'm putting all ACPI header cleanups on hold until all warnings > > > of this kind have been fixed by them. Otherwise doing those cleanups makes a > > > little sense in my opinion. > > > > OK, not only this warning, there is another warning in sfi_acpi.c. > > I doubt whether they are strictly tested before upstreamed... > > They are all existing warnings. > > You can apply my new patch before the cleanup series. > > Sorry, I'm already lost in the thick of patches. :-) > > Please resend them all as a single series. OK, I'll sort them again. Thanks -Lv > > Thanks, > Rafael > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥ ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] SFI: fix compilation warnings 2013-12-06 1:51 ` Zheng, Lv @ 2013-12-09 8:56 ` Andy Shevchenko 0 siblings, 0 replies; 8+ messages in thread From: Andy Shevchenko @ 2013-12-09 8:56 UTC (permalink / raw) To: Zheng, Lv Cc: Rafael J. Wysocki, Wysocki, Rafael J, linux-acpi@vger.kernel.org, LKML On Fri, 2013-12-06 at 01:51 +0000, Zheng, Lv wrote: > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > > Sent: Friday, December 06, 2013 10:01 AM > > To: Zheng, Lv > > Cc: Andy Shevchenko; Wysocki, Rafael J; linux-acpi@vger.kernel.org; LKML > > Subject: Re: [PATCH] SFI: fix compilation warnings > > > > On Friday, December 06, 2013 01:26:07 AM Zheng, Lv wrote: > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > Sent: Friday, December 06, 2013 9:26 AM > > > > > > > > On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote: > > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net] > > > > > > Sent: Friday, December 06, 2013 6:37 AM > > > > > > > > > > > > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote: > > > > > > > When build kernel with make W=1 we get the following compiler error. > > > > > > > > > > > > > > In file included from drivers/sfi/sfi_acpi.c:66:0: > > > > > > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’: > > > > > > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration] > > > > > > > if (!acpi_table_parse(signature, handler)) > > > > > > > ^ > > > > > > > cc1: some warnings being treated as errors > > > > > > > > > > > > > > The patch changes acpi/acpi.h inclusion to linux/acpi.h. > > > > > > > > > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > > > > > > > > > OK > > > > > > > > > > > > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing > > > > > > out entirely for the next cycle. > > > > > > > > > > No, I think Andy's patch is wrong. > > > > > > > > His patch may be wrong, but the warning in his changelog surely is real. :-) > > > > > > > > > This warning is existing before merging my fixes. > > > > > > > > > > Either we fix this warning or leave it as is. > > > > > > > > > > To fix it, you need to add 1 line in sfi_acpi.h rather than change the line. > > > > > Let me post a fix for this. > > > > > > > > Please do. And I'm putting all ACPI header cleanups on hold until all warnings > > > > of this kind have been fixed by them. Otherwise doing those cleanups makes a > > > > little sense in my opinion. > > > > > > OK, not only this warning, there is another warning in sfi_acpi.c. > > > I doubt whether they are strictly tested before upstreamed... > > > They are all existing warnings. > > > You can apply my new patch before the cleanup series. > > > > Sorry, I'm already lost in the thick of patches. :-) > > > > Please resend them all as a single series. > > OK, I'll sort them again. First of all, you are right. We have to have acpi/acpi.h _and_ linux/acpi.h in sfi_acpi.h. Please, also check this one: http://www.mail-archive.com/linux-gpio@vger.kernel.org/msg01521.html -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-12-09 8:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1386264397-27319-1-git-send-email-andriy.shevchenko@linux.intel.com>
2013-12-05 22:36 ` [PATCH] SFI: fix compilation warnings Rafael J. Wysocki
2013-12-05 22:40 ` Rafael J. Wysocki
2013-12-06 1:08 ` Zheng, Lv
2013-12-06 1:25 ` Rafael J. Wysocki
2013-12-06 1:26 ` Zheng, Lv
2013-12-06 2:00 ` Rafael J. Wysocki
2013-12-06 1:51 ` Zheng, Lv
2013-12-09 8:56 ` Andy Shevchenko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox