public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ethan Zhao <ethan.kernel@gmail.com>
To: konrad.wilk@oracle.com, michaelc@cs.wisc.edu, pjones@redhat.com
Cc: linux-kernel@vger.kernel.org, "Ethan Zhao" <ethan.kernel@gmail.com>
Subject: [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()
Date: Mon,  9 Dec 2013 17:37:11 +0800	[thread overview]
Message-ID: <1386581831-312-1-git-send-email-ethan.kernel@gmail.com> (raw)

From: "Ethan Zhao" <ethan.kernel@gmail.com>

Load and unload iscsi_ibft module will cause kernel memory leak, fix it
in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset().

Signed-off-by: Ethan Zhao <ethan.kernel@gmail.com>
---
 drivers/scsi/iscsi_boot_sysfs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/iscsi_boot_sysfs.c b/drivers/scsi/iscsi_boot_sysfs.c
index 14c1c8f..680bf6f 100644
--- a/drivers/scsi/iscsi_boot_sysfs.c
+++ b/drivers/scsi/iscsi_boot_sysfs.c
@@ -490,5 +490,6 @@ void iscsi_boot_destroy_kset(struct iscsi_boot_kset *boot_kset)
 		iscsi_boot_remove_kobj(boot_kobj);
 
 	kset_unregister(boot_kset->kset);
+	kfree(boot_kset);
 }
 EXPORT_SYMBOL_GPL(iscsi_boot_destroy_kset);
-- 
1.8.3.4 (Apple Git-47)


             reply	other threads:[~2013-12-09  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-09  9:37 Ethan Zhao [this message]
2013-12-09 21:30 ` [PATCH] [SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset() Konrad Rzeszutek Wilk
2013-12-10  6:03   ` Ethan Zhao
2013-12-10 14:11     ` Konrad Rzeszutek Wilk
2013-12-10 18:46       ` Mike Christie
2013-12-11 17:18         ` Konrad Rzeszutek Wilk
2013-12-11 17:19           ` Konrad Rzeszutek Wilk
2013-12-11  2:47       ` Ethan Zhao
2013-12-10  0:16 ` Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386581831-312-1-git-send-email-ethan.kernel@gmail.com \
    --to=ethan.kernel@gmail.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox