From: Dave Young <dyoung@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-efi@vger.kernel.org, x86@kernel.org, mjg59@srcf.ucam.org,
hpa@zytor.com, James.Bottomley@HansenPartnership.com,
vgoyal@redhat.com, ebiederm@xmission.com, horms@verge.net.au,
kexec@lists.infradead.org, bp@alien8.de, greg@kroah.com,
matt@console-pimps.org, toshi.kani@hp.com
Subject: [PATCH v5 02/14] efi: use early_memremap and early_memunmap
Date: Mon, 9 Dec 2013 17:42:15 +0800 [thread overview]
Message-ID: <1386582147-9802-3-git-send-email-dyoung@redhat.com> (raw)
In-Reply-To: <1386582147-9802-1-git-send-email-dyoung@redhat.com>
In arch/x86/platform/efi/efi.c and drivers/firmware/efi/efi.c turn to use
early_memremap/early_memunmap instead of early_ioremap/early_iounmap so sparse
will be happy.
Signed-off-by: Dave Young <dyoung@redhat.com>
---
arch/x86/platform/efi/efi.c | 20 ++++++++++----------
drivers/firmware/efi/efi.c | 4 ++--
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index f8ec4da..ef471d5 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -456,7 +456,7 @@ void __init efi_unmap_memmap(void)
{
clear_bit(EFI_MEMMAP, &x86_efi_facility);
if (memmap.map) {
- early_iounmap(memmap.map, memmap.nr_map * memmap.desc_size);
+ early_memunmap(memmap.map, memmap.nr_map * memmap.desc_size);
memmap.map = NULL;
}
}
@@ -493,7 +493,7 @@ static int __init efi_systab_init(void *phys)
efi_system_table_64_t *systab64;
u64 tmp = 0;
- systab64 = early_ioremap((unsigned long)phys,
+ systab64 = early_memremap((unsigned long)phys,
sizeof(*systab64));
if (systab64 == NULL) {
pr_err("Couldn't map the system table!\n");
@@ -524,7 +524,7 @@ static int __init efi_systab_init(void *phys)
efi_systab.tables = systab64->tables;
tmp |= systab64->tables;
- early_iounmap(systab64, sizeof(*systab64));
+ early_memunmap(systab64, sizeof(*systab64));
#ifdef CONFIG_X86_32
if (tmp >> 32) {
pr_err("EFI data located above 4GB, disabling EFI.\n");
@@ -534,7 +534,7 @@ static int __init efi_systab_init(void *phys)
} else {
efi_system_table_32_t *systab32;
- systab32 = early_ioremap((unsigned long)phys,
+ systab32 = early_memremap((unsigned long)phys,
sizeof(*systab32));
if (systab32 == NULL) {
pr_err("Couldn't map the system table!\n");
@@ -555,7 +555,7 @@ static int __init efi_systab_init(void *phys)
efi_systab.nr_tables = systab32->nr_tables;
efi_systab.tables = systab32->tables;
- early_iounmap(systab32, sizeof(*systab32));
+ early_memunmap(systab32, sizeof(*systab32));
}
efi.systab = &efi_systab;
@@ -586,7 +586,7 @@ static int __init efi_runtime_init(void)
* address of several of the EFI runtime functions, needed to
* set the firmware into virtual mode.
*/
- runtime = early_ioremap((unsigned long)efi.systab->runtime,
+ runtime = early_memremap((unsigned long)efi.systab->runtime,
sizeof(efi_runtime_services_t));
if (!runtime) {
pr_err("Could not map the runtime service table!\n");
@@ -606,7 +606,7 @@ static int __init efi_runtime_init(void)
* virtual mode.
*/
efi.get_time = phys_efi_get_time;
- early_iounmap(runtime, sizeof(efi_runtime_services_t));
+ early_memunmap(runtime, sizeof(efi_runtime_services_t));
return 0;
}
@@ -614,7 +614,7 @@ static int __init efi_runtime_init(void)
static int __init efi_memmap_init(void)
{
/* Map the EFI memory map */
- memmap.map = early_ioremap((unsigned long)memmap.phys_map,
+ memmap.map = early_memremap((unsigned long)memmap.phys_map,
memmap.nr_map * memmap.desc_size);
if (memmap.map == NULL) {
pr_err("Could not map the memory map!\n");
@@ -656,14 +656,14 @@ void __init efi_init(void)
/*
* Show what we know for posterity
*/
- c16 = tmp = early_ioremap(efi.systab->fw_vendor, 2);
+ c16 = tmp = early_memremap(efi.systab->fw_vendor, 2);
if (c16) {
for (i = 0; i < sizeof(vendor) - 1 && *c16; ++i)
vendor[i] = *c16++;
vendor[i] = '\0';
} else
pr_err("Could not map the firmware vendor!\n");
- early_iounmap(tmp, 2);
+ early_memunmap(tmp, 2);
pr_info("EFI v%u.%.02u by %s\n",
efi.systab->hdr.revision >> 16,
diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 2e2fbde..b716a66 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -253,7 +253,7 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
if (table64 >> 32) {
pr_cont("\n");
pr_err("Table located above 4GB, disabling EFI.\n");
- early_iounmap(config_tables,
+ early_memunmap(config_tables,
efi.systab->nr_tables * sz);
return -EINVAL;
}
@@ -269,6 +269,6 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
tablep += sz;
}
pr_cont("\n");
- early_iounmap(config_tables, efi.systab->nr_tables * sz);
+ early_memunmap(config_tables, efi.systab->nr_tables * sz);
return 0;
}
--
1.8.3.1
next prev parent reply other threads:[~2013-12-09 9:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 9:42 [PATCH v5 00/14] kexec kernel efi runtime support Dave Young
2013-12-09 9:42 ` [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap Dave Young
2013-12-09 15:05 ` Borislav Petkov
2013-12-10 2:12 ` Dave Young
2013-12-11 10:20 ` Matt Fleming
2013-12-11 11:12 ` Borislav Petkov
2013-12-12 2:06 ` Dave Young
2013-12-09 9:42 ` Dave Young [this message]
2013-12-11 10:39 ` [PATCH v5 02/14] efi: use early_memremap and early_memunmap Matt Fleming
2013-12-11 11:02 ` Leif Lindholm
2013-12-11 11:32 ` Matt Fleming
2013-12-11 15:17 ` Mark Salter
2013-12-13 15:51 ` Leif Lindholm
2013-12-16 1:50 ` Dave Young
2013-12-12 2:04 ` Dave Young
2013-12-11 17:38 ` Borislav Petkov
2013-12-09 9:42 ` [PATCH v5 03/14] efi: remove unused variables in __map_region Dave Young
2013-12-09 9:42 ` [PATCH v5 04/14] efi: add a wrapper function efi_map_region_fixed Dave Young
2013-12-09 9:42 ` [PATCH v5 05/14] efi: reserve boot service fix Dave Young
2013-12-09 9:42 ` [PATCH v5 06/14] efi: cleanup efi_enter_virtual_mode function Dave Young
2013-12-09 9:42 ` [PATCH v5 07/14] efi: export more efi table variable to sysfs Dave Young
2013-12-11 18:32 ` Borislav Petkov
2013-12-12 2:15 ` Dave Young
2013-12-09 9:42 ` [PATCH v5 08/14] efi: export efi runtime memory mapping " Dave Young
2013-12-11 18:55 ` Borislav Petkov
2013-12-12 2:36 ` Dave Young
2013-12-12 7:13 ` Dave Young
2013-12-12 20:36 ` Borislav Petkov
2013-12-13 7:20 ` Dave Young
2013-12-12 20:53 ` Borislav Petkov
2013-12-13 7:26 ` Dave Young
2013-12-13 12:30 ` Matt Fleming
2013-12-16 1:33 ` Dave Young
2013-12-16 3:02 ` Dave Young
2013-12-16 6:02 ` Dave Young
2013-12-09 9:42 ` [PATCH v5 09/14] efi: passing kexec necessary efi data via setup_data Dave Young
2013-12-11 12:13 ` Matt Fleming
2013-12-11 14:05 ` Borislav Petkov
2013-12-12 2:11 ` Dave Young
2013-12-12 2:10 ` Dave Young
2013-12-11 22:20 ` Borislav Petkov
2013-12-12 3:06 ` Dave Young
2013-12-12 6:25 ` Dave Young
2013-12-12 7:17 ` Dave Young
2013-12-12 21:04 ` Borislav Petkov
2013-12-13 7:27 ` Dave Young
2013-12-09 9:42 ` [PATCH v5 10/14] efi: only print saved efi runtime maps instead of all memmap ranges for kexec Dave Young
2013-12-13 16:01 ` Borislav Petkov
2013-12-16 2:00 ` Dave Young
2013-12-16 11:33 ` Borislav Petkov
2013-12-17 6:34 ` Dave Young
2013-12-17 15:58 ` Borislav Petkov
2013-12-18 2:06 ` Dave Young
2013-12-09 9:42 ` [PATCH v5 11/14] x86: add xloadflags bit for efi runtime support on kexec Dave Young
2013-12-09 9:42 ` [PATCH v5 12/14] x86: export x86 boot_params to sysfs Dave Young
2013-12-13 20:04 ` Borislav Petkov
2013-12-09 9:42 ` [PATCH v5 13/14] x86: reserve setup_data ranges late after parsing memmap cmdline Dave Young
2013-12-13 20:04 ` Borislav Petkov
2013-12-09 9:42 ` [PATCH v5 14/14] x86: kdebugfs do not use __va for getting setup_data virt addr Dave Young
2013-12-10 23:25 ` [PATCH v5 00/14] kexec kernel efi runtime support Andrew Morton
2013-12-10 23:32 ` Borislav Petkov
2013-12-10 23:38 ` H. Peter Anvin
2013-12-11 12:37 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386582147-9802-3-git-send-email-dyoung@redhat.com \
--to=dyoung@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bp@alien8.de \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
--cc=toshi.kani@hp.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox