From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754815Ab3LJPuI (ORCPT ); Tue, 10 Dec 2013 10:50:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53604 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754464Ab3LJPuF (ORCPT ); Tue, 10 Dec 2013 10:50:05 -0500 Message-ID: <1386690596.1979.43.camel@deneb.redhat.com> Subject: Re: [PATCH v2 00/11] Consolidate asm/fixmap.h files From: Mark Salter To: Jonas Bonn Cc: "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" Date: Tue, 10 Dec 2013 10:49:56 -0500 In-Reply-To: References: <1385396045-15852-1-git-send-email-msalter@redhat.com> Organization: Red Hat, Inc Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2013-12-10 at 09:48 +0100, Jonas Bonn wrote: > Hi Mark, > > Is there some reason you've excluded OpenRISC here? Did you just miss > it, or does the implementation diverage too much to be usable with > your generic version? It was the runtime BUG() in fix_to_virt() instead of the usual build time check. I thought that might be a toolchain issue and I didn't have a toolchain to try it with. If you're okay with the build time check, I don't see why you couldn't use the generic macros. --Mark