From: Toshi Kani <toshi.kani@hp.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Driver core: Fix device_add_attrs() error code path
Date: Thu, 12 Dec 2013 08:27:19 -0700 [thread overview]
Message-ID: <1386862039.1791.308.camel@misato.fc.hp.com> (raw)
In-Reply-To: <1902491.UTh5DYb76O@vostro.rjw.lan>
On Thu, 2013-12-12 at 06:11 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> If the addition of dev_attr_online fails, device_add_attrs() should
> remove device attribute groups as well as type and class attribute
> groups before returning an error code. Make that happen.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Nice catch!
Acked-by: Toshi Kani <toshi.kani@hp.com>
-Toshi
next prev parent reply other threads:[~2013-12-12 15:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 5:11 [PATCH] Driver core: Fix device_add_attrs() error code path Rafael J. Wysocki
2013-12-12 15:27 ` Toshi Kani [this message]
2013-12-12 23:13 ` Greg Kroah-Hartman
2013-12-13 5:00 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386862039.1791.308.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox