From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, Namhyung Kim <namhyung.kim@lge.com>,
Namhyung Kim <namhyung@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 15/20] tools lib traceevent: Make add_left() return pevent_errno
Date: Fri, 13 Dec 2013 12:12:01 -0300 [thread overview]
Message-ID: <1386947526-7118-16-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1386947526-7118-1-git-send-email-acme@infradead.org>
From: Namhyung Kim <namhyung.kim@lge.com>
So that it can propagate error properly.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1386833777-3790-8-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/parse-filter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
index c08ce594cabe..774c3e4c1d9f 100644
--- a/tools/lib/traceevent/parse-filter.c
+++ b/tools/lib/traceevent/parse-filter.c
@@ -648,7 +648,7 @@ rotate_op_right(struct filter_arg *a, struct filter_arg *b)
return arg;
}
-static int add_left(struct filter_arg *op, struct filter_arg *arg)
+static enum pevent_errno add_left(struct filter_arg *op, struct filter_arg *arg)
{
switch (op->type) {
case FILTER_ARG_EXP:
@@ -667,11 +667,11 @@ static int add_left(struct filter_arg *op, struct filter_arg *arg)
/* left arg of compares must be a field */
if (arg->type != FILTER_ARG_FIELD &&
arg->type != FILTER_ARG_BOOLEAN)
- return -1;
+ return PEVENT_ERRNO__INVALID_ARG_TYPE;
op->num.left = arg;
break;
default:
- return -1;
+ return PEVENT_ERRNO__INVALID_ARG_TYPE;
}
return 0;
}
--
1.8.1.4
next prev parent reply other threads:[~2013-12-13 15:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 15:11 [GIT PULL 00/20] perf/core improvements and fixes Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 01/20] tools lib symbol: Start carving out symbol parsing routines from perf Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 02/20] perf tools: Add perf_event_paranoid() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 03/20] perf header: Allow header->data_offset to be predetermined Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 04/20] perf evlist: Add can_select_event() method Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 05/20] perf tools: Move mem_bswap32/64 to util.c Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 06/20] perf tools: Fix inverted error verification bug in thread__fork Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 07/20] perf evlist: Add perf_evlist__to_front() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 08/20] perf completion: Complete 'perf kvm' Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 09/20] tools lib traceevent: Get rid of malloc_or_die() in show_error() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 10/20] tools lib traceevent: Get rid of die in add_filter_type() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 11/20] tools lib traceevent: Get rid of malloc_or_die() allocate_arg() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 12/20] tools lib traceevent: Get rid of malloc_or_die() in read_token() Arnaldo Carvalho de Melo
2013-12-13 15:11 ` [PATCH 13/20] tools lib traceevent: Get rid of malloc_or_die() in find_event() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 14/20] tools lib traceevent: Get rid of die() in add_right() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` Arnaldo Carvalho de Melo [this message]
2013-12-13 15:12 ` [PATCH 16/20] tools lib traceevent: Get rid of die() in reparent_op_arg() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 17/20] tools lib traceevent: Refactor create_arg_item() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 18/20] tools lib traceevent: Refactor process_filter() Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 19/20] tools lib traceevent: Make pevent_filter_add_filter_str() return pevent_errno Arnaldo Carvalho de Melo
2013-12-13 15:12 ` [PATCH 20/20] tools lib traceevent: Refactor pevent_filter_match() to get rid of die() Arnaldo Carvalho de Melo
2013-12-16 13:54 ` [GIT PULL 00/20] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386947526-7118-16-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).