From: Levente Kurusa <levex@linux.com>
To: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/4] treewide: add missing put_device calls
Date: Fri, 13 Dec 2013 20:22:33 +0100 [thread overview]
Message-ID: <1386962557-8899-1-git-send-email-levex@linux.com> (raw)
Hi,
This is just the beginning of patchset-set that aims to fix possible
problems caused by not calling put_device() if device_register() fails.
The root cause for the need to call put_device() is that the underlying
kobject still has a reference count of 1. Thus, device.release() will not
be called and the device will just sit there waiting for a put_device().
Adding the put_device() also removes the need for the call to kfree() as most
release functions already call kfree() on the container of the device.
While these have not been experienced, they are potential issues and thus
they need to be fixed. Also, they are a few more files that have the same
kind of issue, those will be fixed if these are accepted.
(Sorry for the noise, I messed up my SMTP server so it didn't reach LKML)
The patchset consists of the following patches:
net: phy: call put_device on device_register() failure
eisa: call put_device if device_register fails
backlight: lcd: call put_device if device_register fails
w1: call put_device if device_register fails
diffstat as follows:
drivers/eisa/eisa-bus.c | 4 +++-
drivers/net/phy/mdio_bus.c | 1 +
drivers/video/backlight/lcd.c | 2 +-
drivers/w1/w1_int.c | 5 ++---
4 files changed, 7 insertions(+), 5 deletions(-)
--
Regards,
Levente Kurusa
next reply other threads:[~2013-12-13 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 19:22 Levente Kurusa [this message]
2013-12-13 19:22 ` [PATCH 1/4] net: phy: call put_device on device_register() failure Levente Kurusa
2013-12-13 19:22 ` [PATCH 2/4] eisa: call put_device if device_register fails Levente Kurusa
2013-12-13 19:22 ` [PATCH 3/4] backlight: lcd: " Levente Kurusa
2013-12-13 19:22 ` [PATCH 4/4] w1: " Levente Kurusa
2013-12-14 15:17 ` Evgeniy Polyakov
2013-12-18 23:47 ` Greg KH
2013-12-23 15:37 ` Джамурахметов Рустафа
2013-12-23 15:38 ` Evgeniy Polyakov
2013-12-13 20:42 ` [PATCH 0/4] treewide: add missing put_device calls Bjorn Helgaas
2013-12-14 17:24 ` Greg Kroah-Hartman
2013-12-15 7:55 ` Levente Kurusa
2013-12-15 17:03 ` Greg Kroah-Hartman
2013-12-16 17:18 ` Levente Kurusa
2013-12-16 17:58 ` Greg Kroah-Hartman
2013-12-16 18:11 ` Levente Kurusa
2013-12-16 18:18 ` Greg Kroah-Hartman
2013-12-16 18:24 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386962557-8899-1-git-send-email-levex@linux.com \
--to=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox