public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Levente Kurusa <levex@linux.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Levente Kurusa <levex@linux.com>, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 2/4] eisa: call put_device if device_register fails
Date: Fri, 13 Dec 2013 20:22:35 +0100	[thread overview]
Message-ID: <1386962557-8899-3-git-send-email-levex@linux.com> (raw)
In-Reply-To: <1386962557-8899-1-git-send-email-levex@linux.com>

We need to give up the last reference to edev->dev, so
we need to call put_device().

Cc: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Levente Kurusa <levex@linux.com>
---
 drivers/eisa/eisa-bus.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/eisa/eisa-bus.c b/drivers/eisa/eisa-bus.c
index 272a3ec..8842cde 100644
--- a/drivers/eisa/eisa-bus.c
+++ b/drivers/eisa/eisa-bus.c
@@ -232,8 +232,10 @@ static int __init eisa_init_device(struct eisa_root_device *root,
 static int __init eisa_register_device(struct eisa_device *edev)
 {
 	int rc = device_register(&edev->dev);
-	if (rc)
+	if (rc) {
+		put_device(&edev->dev);
 		return rc;
+	}
 
 	rc = device_create_file(&edev->dev, &dev_attr_signature);
 	if (rc)
-- 
1.8.3.1


  parent reply	other threads:[~2013-12-13 19:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-13 19:22 [PATCH 0/4] treewide: add missing put_device calls Levente Kurusa
2013-12-13 19:22 ` [PATCH 1/4] net: phy: call put_device on device_register() failure Levente Kurusa
2013-12-13 19:22 ` Levente Kurusa [this message]
2013-12-13 19:22 ` [PATCH 3/4] backlight: lcd: call put_device if device_register fails Levente Kurusa
2013-12-13 19:22 ` [PATCH 4/4] w1: " Levente Kurusa
2013-12-14 15:17   ` Evgeniy Polyakov
2013-12-18 23:47     ` Greg KH
2013-12-23 15:37       ` Джамурахметов Рустафа
2013-12-23 15:38       ` Evgeniy Polyakov
2013-12-13 20:42 ` [PATCH 0/4] treewide: add missing put_device calls Bjorn Helgaas
2013-12-14 17:24   ` Greg Kroah-Hartman
2013-12-15  7:55     ` Levente Kurusa
2013-12-15 17:03       ` Greg Kroah-Hartman
2013-12-16 17:18         ` Levente Kurusa
2013-12-16 17:58           ` Greg Kroah-Hartman
2013-12-16 18:11             ` Levente Kurusa
2013-12-16 18:18               ` Greg Kroah-Hartman
2013-12-16 18:24                 ` Levente Kurusa
     [not found] <1386959996-7958-1-git-send-email-levex@linux.com>
     [not found] ` <1386959996-7958-3-git-send-email-levex@linux.com>
2013-12-13 19:04   ` [PATCH 2/4] eisa: call put_device if device_register fails Bjorn Helgaas
2013-12-13 19:08     ` Levente Kurusa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386962557-8899-3-git-send-email-levex@linux.com \
    --to=levex@linux.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox